Repository navigation
Passing custom headers through to http.request() #223
Description
When using HttpEmitter.send() method, how can I pass additional header arguments (e.g. meant for our infrastructure) that are passed through to the http.request() call?
I tried to use
const emitter = new HTTPEmitter({
url: "https://foo.bar"
})
const event = ...
emitter.send(event, {
headers: {
customheader: "...",
authorization: "Bearer ...."
}
})When debugging, it seemed like the passed headers are overwritten by the default headers.
translated to
const config = Object.assign(Object.assign({}, options), defaults);
Activity
lance commentedon Jun 15, 2020
@c-pius it looks like the spread operator assignment is a bug. Thanks for reporting this.
lholmquist commentedon Jun 15, 2020
I wonder if there are other places that are like this?
lholmquist commentedon Jun 15, 2020
To answer my own question. It looks like that is the only spot that the ordering was incorrect
fix: correct the spread order for http_emitter options