Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add support for updating build configuration - #111

Merged
winstliu merged 2 commits into
masterfrom
wl-build-config
Jun 17, 2019
Merged

winstliu merged 2 commits into
masterfrom
wl-build-config

Conversation

@winstliu

Copy link
Copy Markdown
Contributor

This builds off of #110 by adding proper support for updating the build configuration when a build file changes. Previously, a notification would be generated, but none of the options would do anything. Here, I have:

  1. Implemented the callback function for java.projectConfiguration.status, so that no more "Unknown actionableNotification command" messages are generated.
  2. Added a config setting to locally persist the value chosen (as well as persisted by the LS per-session).
  3. Implemented the request to regenerate the build configuration based on the option chosen.
  4. Updated the language/status callback to stop reporting statuses after the server is ready, as additional unneeded messages are reported when updating the build configuration.

Fixes #108

@winstliu
winstliu merged commit 0b0dd6d into master Jun 17, 2019
@winstliu
winstliu deleted the wl-build-config branch June 17, 2019 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language server reports itself as 100% starting, not Ready

1 participant