Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Enable sending configuration changes to the language server - #110

Merged
winstliu merged 5 commits into
masterfrom
wl-preferences
Jun 17, 2019
Merged

winstliu merged 5 commits into
masterfrom
wl-preferences

Conversation

@winstliu

Copy link
Copy Markdown
Contributor

The Eclipse language server contains many preferences that the client can configure to control its behavior. Up until now, there was no way to change any of those preferences. With this PR, I've:

  1. Restructured the package settings to match the structure that the language server expects
  2. Hooked into the relevant atom-languageclient functions so that
    • settings are passed to the language server on load, and
    • the language server receives updated configurations whenever ide-java settings change
  3. Removed the special-casing for the incomplete classpath notification, now that we can properly configure the language server to not send a notification
  4. Exposed the enabling of signature help as an option (and fixed it so that it actually works in the first place)

@winstliu

Copy link
Copy Markdown
Contributor Author

This paves the way for many future enhancements, for example properly handling build configuration notifications (which I plan to send a PR for next).

Winston Liu added 2 commits June 16, 2019 21:57
atom-languageclient should send a workspace/didChangeConfiguration message with the settings on startup
@winstliu

Copy link
Copy Markdown
Contributor Author

/cc @Aerijo just wondering if you have a better idea for the overarching setting group than "server".

@Aerijo

Aerijo commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

wondering if you have a better idea for the overarching setting group than "server"

It's in the settings page, and it's for the server. That heading seems perfectly adequate.

@winstliu
winstliu merged commit 437d5e1 into master Jun 17, 2019
@winstliu
winstliu deleted the wl-preferences branch June 17, 2019 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants