Repository navigation
add schema parameter to table provider factory create method - #4143
Conversation
|
Thanks @milenkovicm. The changes seem reasonable, but could you add some tests? |
|
thanks @andygrove, |
|
@avantgardnerio may be interested in reviewing this as well |
alamb
left a comment
There was a problem hiding this comment.
Thanks -- looks great to me @milenkovicm
Looks like there are now some conflicts but otherwise this PR is ready to go
|
|
||
| assert_eq!(3, table_schema.fields().len()); | ||
|
|
||
| assert_eq!(&DataType::Int32, table_schema.field(0).data_type()); |
| async fn create_external_table_with_ddl() -> Result<()> { | ||
| let mut table_factories: HashMap<String, Arc<dyn TableProviderFactory>> = | ||
| HashMap::new(); | ||
| table_factories.insert("mocktable".to_string(), Arc::new(TestTableFactory {})); |
|
Benchmark runs are scheduled for baseline = 1303543 and contender = 9692fb0. 9692fb0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4142.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
TableProviderFactory::createis a public interface and change will be backward incompatible, but as this interface is in state of flux recently it would make sense to break it now