Skip to content

TableProviderFactory::create should have Optional<DFSchemaRef> parameter #4142

Closed

Description

@milenkovicm

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

datafusion::datasource::datasource::TableProviderFactory::create should have Optional<DFSchemaRef> a parameter to support statements with table DDL e.g: CREATE EXTERNAL TABLE demo_table (c1 integer, c2 integer) STORED AS ... ?

Describe the solution you'd like

add schema: Optional<DFSchemaRef> to method signature

Describe alternatives you've considered

use schema: DFSchemaRef as parameter, which can be empty. I've believe version with Optional make more sense, as it is easier to understand.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions