Repository navigation
Enable TableProviderFactories to receive additional options when creating an external table - #4126
Conversation
|
@avantgardnerio fyi |
Thanks @andygrove . @timvw read my mind - this was actually underway in the early versions of the PR but I abandoned it. LGTM = looks great to me :) |
|
|
||
| // positive case: additional options (one entry) can be specified | ||
| let sql = | ||
| "CREATE EXTERNAL TABLE t STORED AS x OPTIONS ('k1' 'v1') LOCATION 'blahblah'"; |
There was a problem hiding this comment.
I expected to see 'k1' = 'v1' here. Is there a particular SQL dialect being emulated here?
There was a problem hiding this comment.
The k1=v1 is what the code originally did...
After feedback from @avantgardnerio I changed to follow postgresql' create external table [ OPTIONS ( option 'value' [, ... ] ) ]
…Factory to receive entire cmd
|
Benchmark runs are scheduled for baseline = e8fe042 and contender = 2a834d1. 2a834d1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4125.
Are there any user-facing changes?
The user can now provide additional options (depending on the tableprovider(factory)) when creating an external table