[DaanHoogland]

Description

This PR reduces loglevel on non fatal errors and removes stacktraces above debug level.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (60b399f) 29.12% compared to head (6de2f8b) 29.14%.
Report is 7 commits behind head on main.

Files	Patch %	Lines
.../module/model/impl/DefaultModuleDefinitionSet.java	33.33%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8278      +/-   ##
============================================
+ Coverage     29.12%   29.14%   +0.02%     
- Complexity    31030    31054      +24     
============================================
  Files          5193     5193              
  Lines        366322   366330       +8     
  Branches      53558    53562       +4     
============================================
+ Hits         106694   106778      +84     
+ Misses       245013   244908     -105     
- Partials      14615    14644      +29     

Flag	Coverage Δ
simulator-marvin-tests	25.10% <33.33%> (+0.04%)	⬆️
uitests	4.49% <ø> (ø)
unit-tests	14.81% <33.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[JoaoJandre]

LGTM, After the 200th time seeing this stacktrace, it gets boring

[weizhouapache]

LGTM, After the 200th time seeing this stacktrace, it gets boring

me too, same when looked at issue #8218
later found it was added in PR #6890

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7891

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-8449)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 61829 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8278-t8449-kvm-centos7.zip
Smoke tests completed. 118 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3621.14	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	3609.39	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	0.06	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	0.05	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	47.73	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	Error	0.24	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	75.96	test_kubernetes_clusters.py
test_05_vmschedule_test_e2e	Failure	361.79	test_vm_schedule.py
test_05_rvpc_multi_tiers	Failure	354.50	test_vpc_redundant.py

[DaanHoogland]

@weizhouapache @shwstppr can you review?

[shwstppr]

Code change looks good. Should we document somehow about the exceptions for which stacktrace should not be logged with warn/error or will this be a general guideline to not log stacktrace without debug or lower? @DaanHoogland

[DaanHoogland]

Code change looks good. Should we document somehow about the exceptions for which stacktrace should not be logged with warn/error or will this be a general guideline to not log stacktrace without debug or lower? @DaanHoogland

I think we can do that/make it a vote. To me these have always been best practices and I never saw/read something to change my mind. I will send a [DISCUSS] mail on dev@ however.

see https://lists.apache.org/thread/33s0bnwslb0o35ysgqf9t6b8dhvkm7dt