Skip to content

lower level and no stack traces at info or higher #8278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shwstppr merged 1 commit into from
Dec 6, 2023
Merged

lower level and no stack traces at info or higher #8278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .../main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,16 @@ public void with(ModuleDefinition def, Stack<ModuleDefinition> parents) {
log.info(String.format("Starting module [%s].", moduleDefinitionName));
runnable.run();
} catch (BeansException e) {
log.error(String.format("Failed to start module [%s] due to: [%s].", moduleDefinitionName, e.getMessage()), e);
log.warn(String.format("Failed to start module [%s] due to: [%s].", moduleDefinitionName, e.getMessage()));
if (log.isDebugEnabled()) {
log.debug(String.format("module start failure of module [%s] was due to: ", moduleDefinitionName), e);
}
}
} catch (EmptyStackException e) {
log.error(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()), e);
log.warn(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()));
if (log.isDebugEnabled()) {
log.debug("Failed to obtain module context: ", e);
}
}
}
});
Expand All @@ -125,9 +131,15 @@ public void with(ModuleDefinition def, Stack<ModuleDefinition> parents) {
log.debug(String.format("Trying to load module [%s] context.", moduleDefinitionName));
loadContext(def, parent);
} catch (EmptyStackException e) {
log.error(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()), e);
log.warn(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()));
if (log.isDebugEnabled()) {
log.debug("Failed to obtain module context: ", e);
}
} catch (BeansException e) {
log.error(String.format("Failed to load module [%s] due to: [%s].", def.getName(), e.getMessage()), e);
log.warn(String.format("Failed to start module [%s] due to: [%s].", def.getName(), e.getMessage()));
if (log.isDebugEnabled()) {
log.debug(String.format("module start failure of module [%s] was due to: ", def.getName()), e);
}
}
}
});
Expand Down