Add and improve logs in ACS bootstrap process by stephankruggg · Pull Request #6890 · apache/cloudstack

stephankruggg · 2022-11-09T19:06:34Z

Description

ACS bootstrap process contains code that might cause exceptions, which are not logged; thus, it can make it hard for developers and operators to understand what is happening to the system and breaking the boot of the application. This PR intends to improve and add new logs to this process in order to facilitate troubleshooting.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

I applied the changes in a local lab and checked if the messages were being correctly logged.

codecov · 2022-11-09T20:10:01Z

Codecov Report

Merging #6890 (f67c580) into main (1843632) will increase coverage by 16.27%.
Report is 659 commits behind head on main.
The diff coverage is 75.00%.

@@              Coverage Diff              @@
##               main    #6890       +/-   ##
=============================================
+ Coverage     10.87%   27.15%   +16.27%     
- Complexity     7117    28467    +21350     
=============================================
  Files          2485     5119     +2634     
  Lines        245499   417565   +172066     
  Branches      38334    78992    +40658     
=============================================
+ Hits          26699   113379    +86680     
- Misses       215530   289002    +73472     
- Partials       3270    15184    +11914

Flag	Coverage Δ
simulator-marvin-tests	`25.14% <75.00%> (?)`
uitests	`4.87% <ø> (?)`
unit-tests	`14.42% <66.66%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
.../module/model/impl/DefaultModuleDefinitionSet.java	`83.33% <75.00%> (+3.64%)`	⬆️

... and 4007 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarqubecloud · 2022-11-09T20:18:46Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

55.6% Coverage
0.0% Duplication

DaanHoogland

i´d approve if any debug log statements that do parameter evaluation were guarded.

GutoVeronezi

LGTM, I just pointed out a minor improvement.

yadvr · 2023-04-19T07:39:53Z

@blueorangutan package

yadvr · 2023-04-19T07:40:08Z

@blueorangutan package

blueorangutan · 2023-04-19T07:42:06Z

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2023-04-19T08:43:40Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

66.7% Coverage
0.0% Duplication

blueorangutan · 2023-04-19T09:04:10Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5935

yadvr · 2023-05-23T05:27:51Z

@blueorangutan package

blueorangutan · 2023-05-23T05:28:03Z

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-05-23T08:10:45Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6108

GutoVeronezi · 2023-09-11T21:15:28Z

@DaanHoogland @rohityadavcloud can we run the tests for this one?

DaanHoogland · 2023-09-18T09:14:23Z

@blueorangutan package

blueorangutan · 2023-09-18T09:16:07Z

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-09-18T10:26:07Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7042

DaanHoogland · 2023-09-18T12:01:38Z

@blueorangutan test

blueorangutan · 2023-09-18T12:02:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-09-19T00:15:06Z

[SF] Trillian test result (tid-7677)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42426 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6890-t7677-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_05_vmschedule_test_e2e	`Failure`	255.92	test_vm_schedule.py

DaanHoogland · 2023-09-19T07:39:35Z

double check:
@blueorangutan test

blueorangutan · 2023-09-19T07:40:04Z

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-09-19T21:17:22Z

[SF] Trillian test result (tid-7685)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47601 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6890-t7685-kvm-centos7.zip
Smoke tests completed. 110 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	`Failure`	336.60	test_safe_shutdown.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	646.17	test_kubernetes_clusters.py
test_05_vmschedule_test_e2e	`Failure`	265.94	test_vm_schedule.py

shwstppr

Code LGTM

shwstppr · 2023-10-02T06:09:13Z

@blueorangutan package

blueorangutan · 2023-10-02T06:10:04Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-02T07:12:10Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7188

shwstppr · 2023-10-03T09:39:51Z

@blueorangutan test

blueorangutan · 2023-10-03T09:42:04Z

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-10-03T22:22:02Z

[SF] Trillian test result (tid-7818)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44101 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6890-t7818-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	682.74	test_kubernetes_clusters.py

DaanHoogland

in my opinion debug logging should still be guarded if parameter expansion is done, but as I am alone in this opnion I am no longer going to ask for changes in that perspect, the rest looks good.

DaanHoogland · 2023-10-31T14:07:06Z

@GutoVeronezi still want to review?

* Add and improve logs * Fix unnecessary calls --------- Co-authored-by: Stephan Krug <stephan.krug@scclouds.com.br>

This reverts commit 8fa8cef.

Add and improve logs

67df666

stephankruggg changed the title ~~Add and improve logs~~ Add and improve logs in ACS bootstrap process Nov 9, 2022

GaOrtiga approved these changes Nov 22, 2022

View reviewed changes

DaanHoogland reviewed Nov 28, 2022

View reviewed changes

GutoVeronezi approved these changes Nov 28, 2022

View reviewed changes

Comment thread ...src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java Outdated

Fix unnecessary calls

f67c580

yadvr approved these changes Apr 19, 2023

View reviewed changes

yadvr added this to the 4.19.0.0 milestone Apr 19, 2023

yadvr closed this Apr 19, 2023

yadvr reopened this Apr 19, 2023

yadvr approved these changes May 23, 2023

View reviewed changes

DaanHoogland closed this Sep 20, 2023

DaanHoogland reopened this Sep 20, 2023

shwstppr approved these changes Oct 2, 2023

View reviewed changes

DaanHoogland added the status:ready-for-merge label Oct 4, 2023

shwstppr requested a review from DaanHoogland October 9, 2023 08:54

DaanHoogland reviewed Oct 9, 2023

View reviewed changes

GutoVeronezi self-requested a review October 10, 2023 12:22

yadvr merged commit 8fa8cef into apache:main Nov 3, 2023

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 8, 2023

Add and improve logs in ACS bootstrap process (apache#6890)

13a2550

* Add and improve logs * Fix unnecessary calls --------- Co-authored-by: Stephan Krug <stephan.krug@scclouds.com.br>

weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request Nov 13, 2023

Revert "Add and improve logs in ACS bootstrap process (apache#6890)"

8b125c7

This reverts commit 8fa8cef.

weizhouapache mentioned this pull request Dec 1, 2023

lower level and no stack traces at info or higher #8278

Merged

3 of 13 tasks

DaanHoogland removed the status:ready-for-merge label Dec 4, 2024

Conversation

stephankruggg commented Nov 9, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

codecov Bot commented Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud Bot commented Nov 9, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

GutoVeronezi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yadvr commented Apr 19, 2023

Uh oh!

yadvr commented Apr 19, 2023

Uh oh!

blueorangutan commented Apr 19, 2023

Uh oh!

sonarqubecloud Bot commented Apr 19, 2023

Uh oh!

blueorangutan commented Apr 19, 2023

Uh oh!

yadvr commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

GutoVeronezi commented Sep 11, 2023

Uh oh!

DaanHoogland commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 18, 2023

Uh oh!

DaanHoogland commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 19, 2023

Uh oh!

DaanHoogland commented Sep 19, 2023

Uh oh!

blueorangutan commented Sep 19, 2023

Uh oh!

blueorangutan commented Sep 19, 2023

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Oct 2, 2023

Uh oh!

blueorangutan commented Oct 2, 2023

Uh oh!

blueorangutan commented Oct 2, 2023

Uh oh!

shwstppr commented Oct 3, 2023

Uh oh!

blueorangutan commented Oct 3, 2023

Uh oh!

blueorangutan commented Oct 3, 2023

Uh oh!

DaanHoogland left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 31, 2023

Uh oh!

Reviewers

Uh oh!

codecov Bot commented Nov 9, 2022 •

edited

Loading

DaanHoogland left a comment •

edited

Loading