Skip to content

Agent: show the remaining native dialogs in the quit prompt's design - #1601

Merged
AnthonyRonning merged 1 commit into
masterfrom
ux/native-dialogs
Nov 13, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
ux/native-dialogs

Conversation

@matthewrball

@matthewrball matthewrball commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does

  • Every remaining system alert — store attention, a save failure you can retry, the About fallback, the update restart confirm, and the no-tray keep-open prompt — now opens as its own Maple window in the Quit prompt's design: scrim behind the app, calm pill left, coral pill right.
  • Escape and Enter answer the calm action, Tab reaches the coral one, and closing the window answers nothing; an unanswered save-failure warning returns on the next render.
  • The update confirm is one cross-platform path now; the Linux-only in-app overlay is gone.

Store attention:

Store attention before Store attention after

Save failure with retry:

Save failure before Save failure after

About fallback:

About before About after

Update restart confirm:

Update confirm before Update confirm after

No tray (Linux/Windows):

No tray before No tray after

Notes

  • One NativeDialog component in desktop.rs, same shape as the shipped Quit prompt; the overlay's escape/close semantics moved into the dialog's tests.
  • Strings: English, Spanish, German and Korean, all existing keys reused. Rebased onto master including Korean localization from Add Korean localization to Maple Work #1605.
  • Tests: native_dialog_keyboard_answers_calm_then_accent, native_dialog_click_answers_the_clicked_pill, closing_the_native_dialog_answers_nothing; the two store-attention tests were rewritten to the dialog contract.
  • Rebased validation: CI run 43518076372 passed, including unsigned Agent packages for Linux x86_64, macOS ARM64, Windows x64 and Windows ARM64. Local macOS dialog tests and all 34 active localization tests passed.
  • Package smoke: Ubuntu 24.04 x86_64 and Windows 11 ARM64 passed startup, Korean text rendering, window resize/maximize and clean close in fresh stores. Update/store-alert workflows were not manually exercised in these packaged builds.
  • After captures use the committed MAPLE_DEBUG_NATIVE_DIALOG debug hook (like MAPLE_DEBUG_QUIT_LOOP); before captures used a throwaway fixture worktree that is not in the PR. Dark theme only. The startup-error prompt stays a window.prompt until Agent: a startup failure window that says the failure plainly #1594 lands.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@matthewrball
matthewrball marked this pull request as ready for review November 12, 2026 22:35
One NativeDialog window replaces the four remaining window.prompt alerts,
so every dialog matches the Quit prompt: standalone window, scrim behind
the app, calm pill left, coral pill right.

The Linux-only in-app update overlay duplicated the confirm flow for a
constraint (native prompts don't constrain detail text) that the shared
window removes; one cross-platform path replaces it.
@AnthonyRonning AnthonyRonning added the ci:package Build unsigned packages on this PR label Nov 13, 2026
@AnthonyRonning AnthonyRonning removed the ci:package Build unsigned packages on this PR label Nov 13, 2026
@AnthonyRonning
AnthonyRonning merged commit 81850ac into master Nov 13, 2026
23 checks passed
@AnthonyRonning
AnthonyRonning deleted the ux/native-dialogs branch November 13, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants