Repository navigation
Agent: show the remaining native dialogs in the quit prompt's design - #1601
Merged
Merged
Conversation
matthewrball
marked this pull request as ready for review
November 12, 2026 22:35
One NativeDialog window replaces the four remaining window.prompt alerts, so every dialog matches the Quit prompt: standalone window, scrim behind the app, calm pill left, coral pill right. The Linux-only in-app update overlay duplicated the confirm flow for a constraint (native prompts don't constrain detail text) that the shared window removes; one cross-platform path replaces it.
AnthonyRonning
force-pushed
the
ux/native-dialogs
branch
from
November 13, 2026 22:17
13409da to
b8be56a
Compare
AnthonyRonning
approved these changes
Nov 13, 2026
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Store attention:
Save failure with retry:
About fallback:
Update restart confirm:
No tray (Linux/Windows):
Notes
NativeDialogcomponent indesktop.rs, same shape as the shipped Quit prompt; the overlay's escape/close semantics moved into the dialog's tests.native_dialog_keyboard_answers_calm_then_accent,native_dialog_click_answers_the_clicked_pill,closing_the_native_dialog_answers_nothing; the two store-attention tests were rewritten to the dialog contract.MAPLE_DEBUG_NATIVE_DIALOGdebug hook (likeMAPLE_DEBUG_QUIT_LOOP); before captures used a throwaway fixture worktree that is not in the PR. Dark theme only. The startup-error prompt stays awindow.promptuntil Agent: a startup failure window that says the failure plainly #1594 lands.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.