Repository navigation
Agent: add purposeful motion across chat, composer, menus and settings - #1573
Merged
Merged
Conversation
AnthonyRonning
changed the base branch from
codex-gpuibump-adopt
to
codex-gpuibump-maple
November 12, 2026 03:38
AnthonyRonning
force-pushed
the
codex-gpuibump-motion-port
branch
from
November 14, 2026 07:55
acdad79 to
82da17f
Compare
AnthonyRonning
marked this pull request as ready for review
November 14, 2026 16:18
Matt's motion work from #1515, squashed at a587cda and carried onto the newer gpui with no change in behaviour. His branch stays as it is. It adds short, interruptible motion across the app: messages arrive instead of appearing, the composer travels between the empty state and the thread, hover and controls ease, menus open from their trigger, dialogs rise in and Settings sections fade. The rules and tokens are in docs/motion.md, and ui/motion.rs implements them. Changes from his head: - Two merge conflicts with the gpui bump, resolved to his side (the cards above the composer, the send preview). - gpui's rename of on_scroll_wheel to on_scroll in the code he added. - Four test fixtures gained the session summary's thinking_level field, which master added after his branch. Co-Authored-By: Claude <noreply@anthropic.com>
AnthonyRonning
force-pushed
the
codex-gpuibump-motion-port
branch
from
November 14, 2026 16:18
82da17f to
a8c56e6
Compare
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of three PRs in the stack, on top of the gpui bump. This is Matt's motion work from #1515, squashed at his head
a587cdafand carried onto the newer gpui with no change in behaviour. His branch and PR are untouched, so he can keep working there and the two can be compared.It exists for two reasons: to try his motion on the newer gpui as he designed it, and to give the rework above it a base whose diff shows only what the rework changed.
What it adds
Everything described in #1515 and in
apps/maple-agent/docs/motion.md: messages that arrive instead of appearing, the composer travelling between the empty state and the thread, eased hover and controls, menus opening from their trigger, dialogs rising in, and Settings sections fading. The recordings are on #1515.Changes from his head
on_scroll_wheeltoon_scrollin the code he added.thinking_levelfield, which master added after his branch.b1ecb772on Nov 13. Master had since deleted the Linux restart confirmation he restyled (update_confirmation.rs, replaced by the native dialogs of Agent: show the remaining native dialogs in the quit prompt's design #1601), so his change to that file and its test are dropped. Indesktop.rshis screen fade is kept beside master's new dialog scrim.Validation
On macOS, at this head:
cargo test -p maple-agent-app --lockedwith-D warnings: 1,482 passed, 0 failed, 3 ignored. The repository pre-commit hook passed.Not verified
Known issues carried over
These are the review findings on #1515 that the next PR in the stack addresses; none is new here.
hover_background(element, rest, hover)restates the resting colour at 36 call sites, and 18 native hover backgrounds are not migrated.render.cached_child_hover_animates_reverses_and_goes_idle, uses real sleeps.🤖 Generated with Claude Code