Skip to content

Agent: add purposeful motion across chat, composer, menus and settings - #1573

Merged
AnthonyRonning merged 1 commit into
masterfrom
codex-gpuibump-motion-port
Nov 14, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
codex-gpuibump-motion-port

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Second of three PRs in the stack, on top of the gpui bump. This is Matt's motion work from #1515, squashed at his head a587cdaf and carried onto the newer gpui with no change in behaviour. His branch and PR are untouched, so he can keep working there and the two can be compared.

It exists for two reasons: to try his motion on the newer gpui as he designed it, and to give the rework above it a base whose diff shows only what the rework changed.

What it adds

Everything described in #1515 and in apps/maple-agent/docs/motion.md: messages that arrive instead of appearing, the composer travelling between the empty state and the thread, eased hover and controls, menus opening from their trigger, dialogs rising in, and Settings sections fading. The recordings are on #1515.

Changes from his head

  • Two merge conflicts with the gpui bump, both resolved to his side: the cards above the composer and the send preview.
  • gpui's rename of on_scroll_wheel to on_scroll in the code he added.
  • Four test fixtures gained the session summary's thinking_level field, which master added after his branch.
  • Rebased onto master b1ecb772 on Nov 13. Master had since deleted the Linux restart confirmation he restyled (update_confirmation.rs, replaced by the native dialogs of Agent: show the remaining native dialogs in the quit prompt's design #1601), so his change to that file and its test are dropped. In desktop.rs his screen fade is kept beside master's new dialog scrim.

Validation

On macOS, at this head: cargo test -p maple-agent-app --locked with -D warnings: 1,482 passed, 0 failed, 3 ignored. The repository pre-commit hook passed.

Not verified

  • The motion itself in this build. Its Dev package was installed and launched on the Windows ARM64 VM, but the builds that were actually tried and judged are those of the PR above.
  • Linux beyond what CI on this PR reports.

Known issues carried over

These are the review findings on #1515 that the next PR in the stack addresses; none is new here.

  • hover_background(element, rest, hover) restates the resting colour at 36 call sites, and 18 native hover backgrounds are not migrated.
  • Height animation is implemented five ways, and the composer's math repeats layout constants.
  • Transcript and composer animation state advances inside render.
  • One test, cached_child_hover_animates_reverses_and_goes_idle, uses real sleeps.
  • Against a real host, the sent message's row never takes over from its bubble (the hand-off looks the row up under the wrong id), and sending from a tall composer drops the thread for a frame. Tests missed both; the PR above fixes them.
  • The screen and Settings fades paint a cover instead of fading, to work around a cached-view limitation that this gpui no longer has.

🤖 Generated with Claude Code

@AnthonyRonning AnthonyRonning added the ci:package Build unsigned packages on this PR label Nov 11, 2026
@AnthonyRonning
AnthonyRonning removed this pull request from stack #1574 November 12, 2026 03:37
@AnthonyRonning
AnthonyRonning changed the base branch from codex-gpuibump-adopt to codex-gpuibump-maple November 12, 2026 03:38
@AnthonyRonning
AnthonyRonning force-pushed the codex-gpuibump-motion-port branch from acdad79 to 82da17f Compare November 14, 2026 07:55
@AnthonyRonning
AnthonyRonning marked this pull request as ready for review November 14, 2026 16:18
Base automatically changed from codex-gpuibump-maple to master November 14, 2026 16:18
Matt's motion work from #1515, squashed at a587cda and carried onto the
newer gpui with no change in behaviour. His branch stays as it is.

It adds short, interruptible motion across the app: messages arrive
instead of appearing, the composer travels between the empty state and
the thread, hover and controls ease, menus open from their trigger,
dialogs rise in and Settings sections fade. The rules and tokens are in
docs/motion.md, and ui/motion.rs implements them.

Changes from his head:
- Two merge conflicts with the gpui bump, resolved to his side (the
  cards above the composer, the send preview).
- gpui's rename of on_scroll_wheel to on_scroll in the code he added.
- Four test fixtures gained the session summary's thinking_level field,
  which master added after his branch.

Co-Authored-By: Claude <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning force-pushed the codex-gpuibump-motion-port branch from 82da17f to a8c56e6 Compare November 14, 2026 16:18
@AnthonyRonning
AnthonyRonning merged commit 800524d into master Nov 14, 2026
21 checks passed
@AnthonyRonning
AnthonyRonning deleted the codex-gpuibump-motion-port branch November 14, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:package Build unsigned packages on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants