Skip to content

Add Korean localization to Maple Work - #1605

Merged
AnthonyRonning merged 1 commit into
masterfrom
codex-korean-maple
Nov 13, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
codex-korean-maple

Conversation

@w3irdrobot

@w3irdrobot w3irdrobot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Adds 한국어 to Maple Work's language selector, with immediate switching and saved preferences. The complete Korean catalog (Hangul) covers settings, chat, recovery, permission prompts, native menus, integrations, and browser sign-in completion; regional OS locales such as ko-KR resolve to the shared ko catalog. It follows the German addition in #1529.

Includes Korean macOS permission descriptions and translation revision tracking. Commands, confirmation words (DELETE, ERASE), user content, and machine identifiers keep their existing values.

Translation choices

  • Register: sentences use friendly polite 해요체 (~해요, ~하세요, ~할까요?), matching the informal voice of the Spanish and German catalogs. Buttons, menus and labels are short noun forms.
  • Plurals: Korean has one plural category, so counted messages are plain sentences with a counter ({ $count }개) instead of selectors.
  • Particles: no sound-dependent particle directly follows a variable; sentences are restructured or use both forms.
  • Search keywords: the hidden Settings filter terms carry Korean and English words.
  • Glossary: recorded in docs/localization.md (task 작업, local store 로컬 저장소, composer 메시지 입력창, integration 연동, plan 요금제).

The translation is model-produced and was reviewed twice, message by message, by a second model (Codex GPT-6-Astra); its findings are applied. No native Korean speaker has read it yet.

Known limits

  • The bundled Geist, Manrope and Array fonts have no Hangul glyphs, so Korean text uses the platform fallback font. Linux needs an installed Korean font such as Noto Sans CJK KR.
  • Menu type-ahead compares one typed key with a label's first character and has no IME composition, so it cannot match Hangul labels. Arrow keys and Enter work. This predates the change and is documented, not fixed.

Validation

Passed on Linux in the pinned Nix environment: just translations-reviewed ko, just ci-lint, just ci-test (via the pre-commit hook on the final commit), and python3 apps/maple-agent/scripts/test_macos_localization.py.

Not run: just ci-extra (headless build and tests) and root just lane repo.

Runtime: the app was launched on headless Linux with a Korean system locale against a local stack. Sign-in, chat home, Settings and the composer menus rendered Hangul through Noto Sans CJK with no missing glyphs or clipping. That pass predates the switch to 해요체 and the rebase onto the new Quit prompt, so the final wording has not been looked at in the running app. Native macOS and Windows layout, font fallback and permission-dialog checks have not been performed.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Add a complete Korean (ko) catalog in Hangul and register it in the
language selector, the OAuth completion page and the macOS bundle,
following the German addition. Sentences use friendly polite 해요체;
buttons and labels use short noun forms. Korean has one plural
category, so counted messages use counters instead of selectors.

Document the Korean terminology, the reliance on a system fallback
font for Hangul, and that menu type-ahead cannot match Hangul labels.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@w3irdrobot
w3irdrobot marked this pull request as ready for review November 13, 2026 15:11

@AnthonyRonning AnthonyRonning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed c053d40 against the Agent localization contract and the existing German addition (#1529). No blocking findings.

The 2,089-message Korean catalog is complete; interpolation differences are limited to unused plural-selector counts, as expected for Korean. Confirmation words, command snippets and machine values are preserved. Locale registration, saved/live switching coverage, OAuth completion text and macOS permission resources follow the existing pattern.

Validation: ci-ok and the Agent lint/test/macOS/Windows checks are green; CI logs confirm catalog parsing/parity, parameterized formatting, translation revisions and Korean locale/OAuth tests passed. Independently reran scripts/test_macos_localization.py against this revision: 2 tests passed.

The documented native macOS/Windows layout, font-fallback and permission-dialog checks remain release follow-ups, consistent with the German addition.

@AnthonyRonning
AnthonyRonning merged commit c6539d8 into master Nov 13, 2026
41 of 43 checks passed
@AnthonyRonning
AnthonyRonning deleted the codex-korean-maple branch November 13, 2026 21:54
matthewrball added a commit that referenced this pull request Nov 17, 2026
Master gained the Korean catalog (#1605) after this branch was cut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants