Repository navigation
Add Korean localization to Maple Work - #1605
Conversation
Add a complete Korean (ko) catalog in Hangul and register it in the language selector, the OAuth completion page and the macOS bundle, following the German addition. Sentences use friendly polite 해요체; buttons and labels use short noun forms. Korean has one plural category, so counted messages use counters instead of selectors. Document the Korean terminology, the reliance on a system fallback font for Hangul, and that menu type-ahead cannot match Hangul labels. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
AnthonyRonning
left a comment
There was a problem hiding this comment.
Reviewed c053d40 against the Agent localization contract and the existing German addition (#1529). No blocking findings.
The 2,089-message Korean catalog is complete; interpolation differences are limited to unused plural-selector counts, as expected for Korean. Confirmation words, command snippets and machine values are preserved. Locale registration, saved/live switching coverage, OAuth completion text and macOS permission resources follow the existing pattern.
Validation: ci-ok and the Agent lint/test/macOS/Windows checks are green; CI logs confirm catalog parsing/parity, parameterized formatting, translation revisions and Korean locale/OAuth tests passed. Independently reran scripts/test_macos_localization.py against this revision: 2 tests passed.
The documented native macOS/Windows layout, font-fallback and permission-dialog checks remain release follow-ups, consistent with the German addition.
Master gained the Korean catalog (#1605) after this branch was cut.
Adds 한국어 to Maple Work's language selector, with immediate switching and saved preferences. The complete Korean catalog (Hangul) covers settings, chat, recovery, permission prompts, native menus, integrations, and browser sign-in completion; regional OS locales such as
ko-KRresolve to the sharedkocatalog. It follows the German addition in #1529.Includes Korean macOS permission descriptions and translation revision tracking. Commands, confirmation words (
DELETE,ERASE), user content, and machine identifiers keep their existing values.Translation choices
~해요,~하세요,~할까요?), matching the informal voice of the Spanish and German catalogs. Buttons, menus and labels are short noun forms.{ $count }개) instead of selectors.docs/localization.md(task 작업, local store 로컬 저장소, composer 메시지 입력창, integration 연동, plan 요금제).The translation is model-produced and was reviewed twice, message by message, by a second model (Codex GPT-6-Astra); its findings are applied. No native Korean speaker has read it yet.
Known limits
Validation
Passed on Linux in the pinned Nix environment:
just translations-reviewed ko,just ci-lint,just ci-test(via the pre-commit hook on the final commit), andpython3 apps/maple-agent/scripts/test_macos_localization.py.Not run:
just ci-extra(headless build and tests) and rootjust lane repo.Runtime: the app was launched on headless Linux with a Korean system locale against a local stack. Sign-in, chat home, Settings and the composer menus rendered Hangul through Noto Sans CJK with no missing glyphs or clipping. That pass predates the switch to 해요체 and the rebase onto the new Quit prompt, so the final wording has not been looked at in the running app. Native macOS and Windows layout, font fallback and permission-dialog checks have not been performed.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.