Repository navigation
agent: flag stale translations and clean up the catalog - #1489
Merged
Merged
Conversation
Before adding languages, make the catalog cheap to keep correct. - Record the English each translation was reviewed against, and fail a catalog test when English is added, removed or reworded. Run `just translations-reviewed <locale>` after updating the translation. - Remove 76 unused messages and fail a test when a message has no production caller. - Rename positional `$argN` variables and give every message variable a translator comment, enforced by a test. - Use computadora for computer in Spanish, as the glossary says. 63 lines used equipo, which the glossary keeps for team. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 7, 2026
AnthonyRonning
added a commit
that referenced
this pull request
Nov 7, 2026
#1488 added twelve messages with their Spanish text but no review record. Its CI ran before #1489 added the stale-translation check, so master's agent-test and agent-full-macos now fail in translations_were_reviewed_against_the_current_english. Generated with `just translations-reviewed es`. The Spanish text is unchanged. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Agent translation catalog cheap to keep correct before we add more languages. These are the catalog follow-ups left over from #1372. Dispatch consolidation and locale observers stay separate.
What changed
app/translation-revisions/es.txtrecords the English each Spanish message was reviewed against. If English is added, removed or reworded, a test fails and names the messages. After updating them, runjust translations-reviewed es. Comment edits don't count as changes.&'static str, so every live key has to appear as a literal in the source.$argNnow have real names, and 135 translator comments were added or rewritten. A test requires a comment for each variable and rejects positional names.computadorafor computer in Spanish. The glossary already said this, but 63 lines usedequipo, which it keeps for team. Three moresettings-remote-refused-*lines changed because they relied on the old noun's gender.equiponow only means team.Testing
just ci-lintandjust ci-testpassed through the pre-commit hook, including 1,311 app tests and 857 core tests.$arg1were each caught and named. A comment-only edit was correctly not flagged.Not seen live:
settings-pairing-expiry, because this debug build has no remote relay, and the other renamed messages that need a specific state, such assettings-shortcut-collision,settings-credits-costandsettings-api-key-created. The script covers these. This branch hasn't been run on Windows either;ci:windowsruns the test suite there, including the CRLF handling in the revision check.For reviewers
es.txtcan't prove anyone translated anything. A changed revision line should come with a changed translation.computadorarewrite wasn't reviewed by a native speaker. The newComputadoras remotasSettings label is shorter thanInstrucciones adicionalesin the same column.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.