Repository navigation
agent: extend live Mexican Spanish localization across the app - #1372
Conversation
ca02ff9 to
da4c255
Compare
da4c255 to
105cac0
Compare
|
Localization preview gate, captured from the rebuilt Linux desktop on this PR. Default: gate unset — no Language selector Opt-in: The gate applies to unpackaged, Dev, and Prod builds. Quit and reopen after changing it. Disabling the gate preserves the saved language preference; these screenshots show it returning when re-enabled. English is the only shipped catalog. These are offline Settings checks using the disposable MDE profile; they do not claim hosted Dev/Prod integration. The previously reported GPUI quit panic remains. Images are pinned to an evidence-only commit, outside the application diff. |
Screencast_20261102_172412.webm |
|
could be worth seeing spanish or a 2nd language here to see it flip and work? |
|
Spanish preview of the existing Fluent surfaces, captured from the rebuilt Linux desktop with English Español — after selecting it and restarting Maple Spanish language picker The saved Español preference survives desktop restart, and the language control's accessibility label changes to Spanish preview pushed in |
|
Language changes now show a restart notice beneath the selector, with Later / Restart now in the current UI language. English UI, Español selected Spanish UI, English selected Later dismisses the notice for the current Settings visit. Reopening Settings reminds again while the choice is pending; selecting the active language clears it. Restart now uses the existing quit coordinator, flushes settings, and stops the host before relaunching. Cancelling Quit cancels the restart, and an update installation cannot be interrupted by this action. Native Linux verification exercised language selection, Later, reopening Settings, and Restart now relaunching into Spanish. Accessibility labels for both buttons were checked in English and Spanish. These captures use a copy of a disposable Local profile with backend services stopped; no inference requests or new account login were submitted. Native macOS/Windows behavior remains unverified. Pushed in |
Screencast_20261103_115834.webm |
|
General settings now has complete Spanish coverage, including all row descriptions, theme/font/voice options, preview text, test notification and shared Settings navigation. Persisted values and control IDs are unchanged. The speech voice menu is wider to fit the translated labels. EnglishEspañolSpanish voice choicesValidation: Linux Agent |
|
Static review of Direction1. Drop 2. Evaluate live switching before committing to restart-to-apply. Theme switching already works live (
The general rule that would make this sustainable: keep keys or enums in state and format at render. How much work this is depends on how many views store strings, which is exactly what the full-translation experiment below would show. If it turns out significantly harder, postponing it is fine. 3. If a restart stays, show the restart notice in the language just chosen. Someone switching to Español should read "Reinicia Maple…" rather than the old language. This should be cheap: look up the notice strings with the pending preference's resolved locale instead of the active one. The quit prompt shown during that restart should match too; today its button label is translated but its title and message aren't. 4. A stacked PR that translates the whole app before this merges. Once we're happy with the single-page design here, a follow-up PR on top of this one should convert 100% of the UI. It would show whether these patterns hold up at full scale (key naming, the inline-literal guard, IDs, live switching) before we commit to them. For scale, there are roughly 180 inline Findings, by categoryMust fix before merge (OS-specific)
Should fix in this PR
Document, or fix in the stacked PR
Verified fine
|
Screencast_20261103_142221.webm |
|
Live switching now replaces restart-to-apply, and the environment gate is removed. Verified English → Español → English in one Linux desktop process (PID 1457138) and the same window, with MAPLE_ENABLE_LOCALIZATION absent. Settings labels, navigation, preview text and accessibility labels changed immediately, with no restart notice. English Español, immediately after selection English again, same process Captures use an isolated disposable Local profile with backend services stopped. Native macOS/Windows runtime is not verified. Regression coverage includes repeated selection, cache invalidation and an already-open update dialog changing its title. Validation: Linux Pushed in |
|
Live language switching in General settings: English → Español → English, in one continuous screen recording with the same app process and window. No restart and no localization environment variable. Recorded from commit live-language-switch.mp4 |
|
Expanded Spanish coverage to every Settings page and their local forms, notices, shortcut labels/search, and remote controls. Language changes apply immediately without clearing typed form values. Screenshots below are from the final Linux debug executable in an isolated X11 preview, using copied local test data. Matching English/Spanish views show Shortcuts, Integrations, and Privacy & Security; additional Spanish captures show Local API and the encryption password form. The longer Spanish safety text now fits inside the password card. Preview API: loopback port 31270; billing: loopback port 9 (unavailable). No production endpoints. Account/billing success states, real remote pairing/update actions, and macOS/Windows runtime behavior were not verified. Backend errors and host-owned integration diagnostics (for example, “Signed in”) remain untranslated. |
# Conflicts: # apps/maple-agent/app/locales/en/app.ftl # apps/maple-agent/app/locales/es/app.ftl # apps/maple-agent/app/src/ui/i18n/tests.rs # apps/maple-agent/app/src/ui/text_input.rs
…nt-i18n # Conflicts: # apps/maple-agent/app/locales/en/app.ftl # apps/maple-agent/app/locales/es/app.ftl # apps/maple-agent/app/src/backend/local.rs # apps/maple-agent/app/src/ui/chat/mod.rs # apps/maple-agent/app/src/ui/chat/transcript.rs # apps/maple-agent/app/src/ui/i18n/tests.rs # apps/maple-agent/app/src/ui/store_gate.rs # apps/maple-agent/app/src/ui/store_gate/password_form_tests.rs
Carry typed host failures through chat, settings, login and recovery UI without freezing notices at the previous locale. Preserve receipt diagnostics, task and account fences, sidebar write ordering and legacy protocol responses. Add semantic attachment staging errors, nested UI message contexts and transient local-error presentation with locale, cancellation and recovery regressions.
# Conflicts: # apps/maple-agent/app/locales/en/app.ftl # apps/maple-agent/app/locales/es/app.ftl
|
Final merged Linux desktop preview at The preview used an isolated copy of local test data, local offline API/billing endpoints, and the pinned Nix Mesa/Vulkan environment. The raw authentication diagnostic is intentionally shown through legacy fallback; no account/billing/provider success is claimed. macOS/Windows runtime checks remain unverified here. |
|
Merge commit: Resolved the master merge and extended Mexican Spanish coverage to the new integration app catalog and replacement ACP setup page. Includes all 25 app summaries, categories/search, connection controls, token labels/placeholders/validation, and ACP setup instructions/copy labels. The isolated Linux desktop preview verified English → Spanish → English switching without restart. The token form stayed open and its retained validation notice changed languages too. Generated configuration, saved descriptions, commands, and external app menu names remain exact. No credentials were entered or provider sign-in performed. |
f7c84b7 to
44ab309
Compare
|
@w3irdrobot, this is Claude, posting for Anthony. He asked me to review this PR and test it on a real Mac with a local Pro account. Verdict: keep the approach, but don't merge yet. Nothing needs a redesign. Fluent, live switching and the semantic failure codes all held up in real use, and I found no data-safety regressions in the password, repair, send or erase flows. What's left is a Windows gap, four fixes and some cleanup. I tested WindowsClippy and the Windows package lanes are green now, so the compile break is fixed. They don't run the app's tests, though. The full suite ( Nobody has run the app on Windows yet, and that includes me. Merging commits us to i18n, so someone should do that first: language switching, native menus and prompts, and how text renders with DirectWrite. Fix before merge
Fix soonThese don't have to block the merge.
What held upTested live on macOS with a debug bundle and a local Pro fixture:
From Anthony's Nov 3 list, the gate removal, live switching, stable row IDs and One macOS limit is worth knowing: with Spanish in Maple on an English Mac, Not tested
|
44ab309 to
83ae69f
Compare
|
Review follow-up: live spelling and menu layout checked on Linux using the isolated offline fixture. The same unsent draft survived English → Spanish → English. English-dictionary underlines disappear in Spanish and return in English, without restarting. The Spanish project action labels fit in full. The fixture intentionally has no initialized provider authentication; the visible startup diagnostic is an expected raw fallback, not a provider-success test. No request was submitted. |
|
@w3irdrobot, this is Claude again, posting for Anthony. I rechecked Code fix: language resets after a host reconnectIf someone's saved language differs from their OS language, a host reconnect switches the whole UI to the OS language. The setting stays as saved, and it lasts until the next restart. This came in with the store-language fix. To reproduce: I had English saved on a Spanish OS. I killed the Cause:
From reading the code, store maintenance from Settings ( Suggested fix (untested): remove the clear at Rebase and conflict cleanupThe PR conflicts with master Most of these need more than picking a side. Master changed
WindowsWe'll still want to test on Windows before merging, on the rebased head. |
Compile the private-directory staging failure and its UI mapping only where the Unix permission check can construct it. This fixes warning-denied Windows lint and x64/ARM64 packaging builds while retaining the Unix rejection path.
565d011 to
195f398
Compare
|
@AnthonyRonning Addressed in
Full pinned Linux The rebased CI run is running with |
fmt-check failed on one `if` expression in the regression test added for host reconnects. No behavior changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AnthonyRonning
left a comment
There was a problem hiding this comment.
Smoke tested and approved.







































Adds live English/Mexican Spanish localization across Settings, chat, composer/sidebar, project dialogs, sign-in, local-store/recovery flows, native menus/tray controls and desktop dialogs. English is the source of truth. Includes the current 24-app integration catalog and ACP setup page; preserves master's removal of GitHub's token-based catalog flow.
Language changes retain drafts, task selection, filters and scroll anchors. Background operations carry semantic failures until UI formatting. Raw user/model content, commands, confirmation tokens, source records and send-receipt recovery diagnostics stay unchanged.
The review fixes disable English spellchecking while Spanish is selected, translate Maple-owned provider error bodies without changing retry diagnostics, disable Fluent's invisible bidi isolation marks, and fall back to raw text when optional error/timeline metadata is malformed. Response identity, authoritative results and row identities remain strictly decoded. Also fixes store-locale reset, missing UI notices/hints, clipped Spanish menus, wrapped disconnect notices, locale-dependent paging hashes and the duplicated sign-in-page CSP definition.
Rebased onto master
663eb20b. Same-store host reconnects and password maintenance now preserve the saved language; locking or replacing the store still clears it for the next hydration. Regression tests exercise the production event/response path. Master’s accessible text wrappers retain translated labels, and the localization guard now parsestext!arguments to detect inline English and missing translation keys. The duplicate sign-in-template attributes rule was removed in favor of master’s equivalent rule.Hosted OAuth captures a bounded locale per local attempt. macOS bundles declare English/Spanish and include Spanish permission resources. Unknown/third-party diagnostics, legacy string-only events and receipts, initial remote-upload admission errors, and the Windows NSIS installer retain their raw/English fallback. Spanish spellcheck dictionaries remain future work.
Validation on Linux: pinned
CARGO_INCREMENTAL=0 RUST_TEST_THREADS=1 just cipassed (exit 0): core 859 passed/5 ignored, app 1,310 passed/3 ignored, headless 373 passed/2 ignored; all Clippy feature configurations, dependency checks and all-target build passed. Rootjust lane repoalso passed (562 tests, 2 skipped). Earlier interrupted runs and the corrected sidebar test fixture are superseded by this complete green run. Windows CI is requested withci:windows; real Windows runtime behavior remains unverified.Linux preview verified the same unsent draft through English → Spanish → English: English spellcheck underlines disappear in Spanish and return in English, with no restart or draft loss. Spanish project actions fit in full and the edit menu shows no English spelling suggestions. Screenshots are attached in a PR comment. The isolated offline fixture does not verify account/billing/provider success. It lacks an AT-SPI service, so it does not establish accessibility-runtime evidence.
Nonblocking follow-ups: consolidate presented dispatch in the operations macro, replace render-time locale polling with global observers, and improve catalog maintenance/stale-translation checks. A terminology glossary is documented. Real Windows language switching, native menus/prompts and DirectWrite rendering still require a Windows smoke test; CI is separate evidence. The macOS review also reported that AppKit-owned labels follow the OS language and Full Screen can disappear when Maple is Spanish on an English OS.