Repository navigation
fix(agent): record the Spanish review of the address strings - #1493
Merged
Merged
Conversation
#1488 added twelve messages with their Spanish text but no review record. Its CI ran before #1489 added the stale-translation check, so master's agent-test and agent-full-macos now fail in translations_were_reviewed_against_the_current_english. Generated with `just translations-reviewed es`. The Spanish text is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's
agent-testandagent-full-macosfail on every run intranslations_were_reviewed_against_the_current_english:#1488 added these twelve messages, with Spanish, but no review record. Its last CI ran at 07:40 UTC, before #1489 added the stale-translation check at 08:17, and it merged at 16:51 without a rerun on the new master. Tonight's scheduled CI will fail the same way until this lands.
This adds the twelve missing lines to
translation-revisions/es.txt, generated withjust translations-reviewed es. The catalogs themselves are unchanged.Tested: the
ui::i18n::testsmodule passed (32 passed), and the pre-commit hook's full Agent lint and test run passed (app: 1319 passed).Last night's scheduled failure was a different, intermittent macOS test (
transcript_context_menu_copies_link_destinations), which will be fixed in a separate PR.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.