Skip to content

fix(agent): record the Spanish review of the address strings - #1493

Merged
AnthonyRonning merged 1 commit into
masterfrom
fix/agent-es-review-stamps
Nov 7, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
fix/agent-es-review-stamps

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Master's agent-test and agent-full-macos fail on every run in translations_were_reviewed_against_the_current_english:

English changed for {"runtime-error-mcp-invalid-address", ..., "settings-catalog-summary-vana"}.
Update these in app/locales/es/app.ftl, then run `just translations-reviewed es`.

#1488 added these twelve messages, with Spanish, but no review record. Its last CI ran at 07:40 UTC, before #1489 added the stale-translation check at 08:17, and it merged at 16:51 without a rerun on the new master. Tonight's scheduled CI will fail the same way until this lands.

This adds the twelve missing lines to translation-revisions/es.txt, generated with just translations-reviewed es. The catalogs themselves are unchanged.

Tested: the ui::i18n::tests module passed (32 passed), and the pre-commit hook's full Agent lint and test run passed (app: 1319 passed).

Last night's scheduled failure was a different, intermittent macOS test (transcript_context_menu_copies_link_destinations), which will be fixed in a separate PR.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

#1488 added twelve messages with their Spanish text but no review
record. Its CI ran before #1489 added the stale-translation check, so
master's agent-test and agent-full-macos now fail in
translations_were_reviewed_against_the_current_english.

Generated with `just translations-reviewed es`. The Spanish text is
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit 12d8da1 into master Nov 7, 2026
23 checks passed
@AnthonyRonning
AnthonyRonning deleted the fix/agent-es-review-stamps branch November 7, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant