Skip to content

ci: fix comments left stale by the recent CI changes - #1345

Merged
AnthonyRonning merged 1 commit into
masterfrom
ci/stale-comments
Oct 28, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
ci/stale-comments

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes comments that went stale during the recent CI changes. Comments only; no behaviour changes.

  • codeql.yml: a release needs the newest finished scan to be green, not a scan of the exact commit (PR #1339, the CodeQL release rule).
  • agent-desktop-build.yml: PRs rehearse packaging only with ci:package or ci:full (PR #1337, label-only packaging).
  • ci.yml: the packaging cache is saved only by the nightly run, not master pushes, and the nightly runs the nightly lanes, not every lane.
  • lanes.py: C5 covers FlakeHub EIF builders, not every EIF build.
  • setup-hooks.sh: the Research hook runs cargo fmt and tests, not Clippy.
  • test_plan.py: docstring no longer mentions the removed benchmark lane.

The change-maple-ci skill also gets a new rule: comments and docs change in the same PR as the behaviour they describe.

This PR runs the gate lanes (it edits ci.yml and lanes.py). Merging it runs one normal signed Agent Prod build (it edits agent-desktop-build.yml), and no Research builds.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

#1339 changed the CodeQL release rule, #1337 made packaging rehearsals
label-only and gave them a nightly-saved cache, and #1341 left the EIF
runner comment broader than C5. Older: the nightly does not run every
lane, the Research hook runs no Clippy, and the Agent lane tests no
longer cover a benchmark. The CI skill now says comments and docs move
with behaviour in the same PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit 02adadb into master Oct 28, 2026
69 of 71 checks passed
@AnthonyRonning
AnthonyRonning deleted the ci/stale-comments branch October 28, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant