Skip to content

ci: no PR waits on a packaging or desktop bundle build - #1337

Merged
AnthonyRonning merged 2 commits into
masterfrom
ci/fast-prs
Oct 28, 2026
Merged

AnthonyRonning merged 2 commits into
masterfrom
ci/fast-prs

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Every lane a pull request waits on now takes a few minutes. Desktop bundles and packaging rehearsals (15–45 min each) no longer run on PRs because a path changed.

Replay of the last 100 merged PRs, with measured lane times:

ci-ok p50 p90 PRs over 10 min
master today 6.9 min 27 min 22 / 100
this PR 4.2 min 7.1 min 2 / 100 (both labelled on purpose)

What changes

  • Label-only on PRs: agent-package-{linux,macos,windows}, research-desktop-{linux,macos,windows} and research-dev-macos.
    • Before, their path selectors put them on 22 of the last 100 PRs, which then waited 20–40 min.
    • They now run with ci:package or ci:full (ci:research-dev-macos too).
    • The Agent packages also run nightly.
    • Master still builds the real signed packages in agent-desktop-build.yml and desktop-build.yml, as the CI design intended.
  • agent-windows-updater:
    • Runs on the free windows-2025 runner. On 16 cores it queued about 2 min for a 2-second suite.
    • Also runs when the Agent workspace Cargo.lock or Cargo.toml changes.
    • Runs serially with --no-fail-fast.
  • research-desktop-windows: onnxruntime-pins.sh, which holds the Windows ONNX Runtime, VC++ and WiX pins, now selects it under the ci:package label.

When to add ci:package

When a PR changes packaging or release scripts, the flakes or toolchains, or what ships in a bundle. docs/ci.md says so in its Labels section.

Local checks pass: plan.py lint, the scripts/ci suite (509), the publisher tests, the release gates and actionlint.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

AnthonyRonning and others added 2 commits October 28, 2026 02:23
- Run agent-windows-updater on the free windows-2025: on 16 cores the
  2 s suite queued about 2 min for a runner, so it bought no wall time.
- Select it on the Agent workspace's Cargo.lock and Cargo.toml, its
  dependency inputs, and on CI edits (gate), now that it costs nothing.
- Run it serially with --no-fail-fast, as the deleted harness did, so a
  lib failure still reports the bootstrap tests.
- Select research-desktop-windows on onnxruntime-pins.sh, which holds
  the Windows ONNX Runtime, VC++ and WiX pins.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Agent packaging rehearsals and the Research desktop and Dev bundles
take 15-45 minutes, and their path selectors put them on 22 of the last
100 merged PRs, so those PRs waited 20-40 minutes for ci-ok. They now
run only with ci:package (or ci:full, ci:research-dev-macos), nightly
for the Agent packages, and as the real signed builds on master
(agent-desktop-build.yml, desktop-build.yml), as the CI design intended.

Replaying the last 100 merged PRs with measured lane times: ci-ok p50
6.9 -> 4.2 min, p90 27 -> 7 min; PRs over 10 minutes 22 -> 2 (both
labelled on purpose).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit 857bacb into master Oct 28, 2026
69 of 71 checks passed
@AnthonyRonning
AnthonyRonning deleted the ci/fast-prs branch October 28, 2026 02:43
AnthonyRonning added a commit that referenced this pull request Oct 28, 2026
#1339 changed the CodeQL release rule, #1337 made packaging rehearsals
label-only and gave them a nightly-saved cache, and #1341 left the EIF
runner comment broader than C5. Older: the nightly does not run every
lane, the Research hook runs no Clippy, and the Agent lane tests no
longer cover a benchmark. The CI skill now says comments and docs move
with behaviour in the same PR.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant