Repository navigation
ci: no PR waits on a packaging or desktop bundle build - #1337
Merged
Merged
Conversation
- Run agent-windows-updater on the free windows-2025: on 16 cores the 2 s suite queued about 2 min for a runner, so it bought no wall time. - Select it on the Agent workspace's Cargo.lock and Cargo.toml, its dependency inputs, and on CI edits (gate), now that it costs nothing. - Run it serially with --no-fail-fast, as the deleted harness did, so a lib failure still reports the bootstrap tests. - Select research-desktop-windows on onnxruntime-pins.sh, which holds the Windows ONNX Runtime, VC++ and WiX pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Agent packaging rehearsals and the Research desktop and Dev bundles take 15-45 minutes, and their path selectors put them on 22 of the last 100 merged PRs, so those PRs waited 20-40 minutes for ci-ok. They now run only with ci:package (or ci:full, ci:research-dev-macos), nightly for the Agent packages, and as the real signed builds on master (agent-desktop-build.yml, desktop-build.yml), as the CI design intended. Replaying the last 100 merged PRs with measured lane times: ci-ok p50 6.9 -> 4.2 min, p90 27 -> 7 min; PRs over 10 minutes 22 -> 2 (both labelled on purpose). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 28, 2026
AnthonyRonning
added a commit
that referenced
this pull request
Oct 28, 2026
#1339 changed the CodeQL release rule, #1337 made packaging rehearsals label-only and gave them a nightly-saved cache, and #1341 left the EIF runner comment broader than C5. Older: the nightly does not run every lane, the Research hook runs no Clippy, and the Agent lane tests no longer cover a benchmark. The CI skill now says comments and docs move with behaviour in the same PR. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every lane a pull request waits on now takes a few minutes. Desktop bundles and packaging rehearsals (15–45 min each) no longer run on PRs because a path changed.
Replay of the last 100 merged PRs, with measured lane times:
What changes
agent-package-{linux,macos,windows},research-desktop-{linux,macos,windows}andresearch-dev-macos.ci:packageorci:full(ci:research-dev-macostoo).agent-desktop-build.ymlanddesktop-build.yml, as the CI design intended.agent-windows-updater:windows-2025runner. On 16 cores it queued about 2 min for a 2-second suite.Cargo.lockorCargo.tomlchanges.--no-fail-fast.research-desktop-windows:onnxruntime-pins.sh, which holds the Windows ONNX Runtime, VC++ and WiX pins, now selects it under theci:packagelabel.When to add
ci:packageWhen a PR changes packaging or release scripts, the flakes or toolchains, or what ships in a bundle.
docs/ci.mdsays so in its Labels section.Local checks pass:
plan.py lint, the scripts/ci suite (509), the publisher tests, the release gates and actionlint.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.