Repository navigation
release: a release no longer waits for CodeQL to finish - #1339
Merged
Merged
Conversation
The preflight required a successful CodeQL run on the exact release commit, so a release waited 30-47 minutes after every merge. Now the newest finished CodeQL scan of the release commit or an ancestor must be green: a scan still running (or cancelled) does not block, a red one does, and later commits' scans are not part of the release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 28, 2026
AnthonyRonning
added a commit
that referenced
this pull request
Oct 28, 2026
#1339 changed the CodeQL release rule, #1337 made packaging rehearsals label-only and gave them a nightly-saved cache, and #1341 left the EIF runner comment broader than C5. Older: the nightly does not run every lane, the Research hook runs no Clippy, and the Agent lane tests no longer cover a benchmark. The CI skill now says comments and docs move with behaviour in the same PR. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Research release no longer waits for CodeQL to finish. Before, the release preflight required a successful CodeQL run on the exact release commit, so a release waited 30–47 minutes after every merge.
The new rule
The newest finished CodeQL scan of the release commit or one of its ancestors must be green.
Checked against live data: master's own scan of 857bacb was still running, and the preflight used the green scan of ba50f24 instead of waiting.
Not changed
CodeQL still runs on every master push, nightly and on dispatch, on GitHub's free runner.
On
blacksmith-32vcpu, the Rust analysis took 13.5 min instead of 30–47 min (run 40623379361). Now that nothing waits on it, that would cost about $0.86 per master push for no wait saved, so it stays on GitHub's free runner.Tests:
test_ci_evidence.py(20, with new cases for running, cancelled, red, later-commit and ancestor scans), plus the release gates, the scripts/ci suite and actionlint.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.