Skip to content

release: a release no longer waits for CodeQL to finish - #1339

Merged
AnthonyRonning merged 1 commit into
masterfrom
ci/codeql-fast
Oct 28, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
ci/codeql-fast

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

A Research release no longer waits for CodeQL to finish. Before, the release preflight required a successful CodeQL run on the exact release commit, so a release waited 30–47 minutes after every merge.

The new rule

The newest finished CodeQL scan of the release commit or one of its ancestors must be green.

  • A scan that is still running, or was cancelled, does not block. The previous finished scan counts instead.
  • A red scan blocks, even if an older green scan exists.
  • Scans of later master commits are not part of the release, so they are ignored.

Checked against live data: master's own scan of 857bacb was still running, and the preflight used the green scan of ba50f24 instead of waiting.

Not changed

CodeQL still runs on every master push, nightly and on dispatch, on GitHub's free runner.

On blacksmith-32vcpu, the Rust analysis took 13.5 min instead of 30–47 min (run 40623379361). Now that nothing waits on it, that would cost about $0.86 per master push for no wait saved, so it stays on GitHub's free runner.

Tests: test_ci_evidence.py (20, with new cases for running, cancelled, red, later-commit and ancestor scans), plus the release gates, the scripts/ci suite and actionlint.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

The preflight required a successful CodeQL run on the exact release
commit, so a release waited 30-47 minutes after every merge. Now the
newest finished CodeQL scan of the release commit or an ancestor must be
green: a scan still running (or cancelled) does not block, a red one
does, and later commits' scans are not part of the release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit acd9f53 into master Oct 28, 2026
19 checks passed
@AnthonyRonning
AnthonyRonning deleted the ci/codeql-fast branch October 28, 2026 03:08
AnthonyRonning added a commit that referenced this pull request Oct 28, 2026
#1339 changed the CodeQL release rule, #1337 made packaging rehearsals
label-only and gave them a nightly-saved cache, and #1341 left the EIF
runner comment broader than C5. Older: the nightly does not run every
lane, the Research hook runs no Clippy, and the Agent lane tests no
longer cover a benchmark. The CI skill now says comments and docs move
with behaviour in the same PR.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant