Repository navigation
Clean up compiler warnings that don't involve concurrency - #2567
Merged
Merged
Conversation
- Live Activity: an activity preset fell through @unknown default and showed an empty title. It now shows its preset's name and symbol, and the switch is exhaustive so a new context can't be missed again. - Throwing tasks whose errors were dropped now log them. Retracting the unsafe-notification-permissions alert dismisses the in-app alert even if recording the retraction fails, and the insulin delivery log opens a dose's details even if its dosing decision can't be found. - Mark conformances of types and protocols from other modules @retroactive. - Move off deprecated APIs: onChange(of:perform:), traitCollectionDidChange (now registerForTraitChanges with the traits that affect colours), HKCategoryValueSleepAnalysis.asleep, WKExtension.applicationWillResignActiveNotification. - Remove unused values and the tuple-pattern warning.
This was referenced Oct 12, 2026
ps2
added a commit
to LoopKit/LoopWorkspace
that referenced
this pull request
Oct 12, 2026
Brings in the VoiceOver label fixes (LoopKit/Loop#2569, LoopKit/LoopKit#640, loopandlearn/OmnipodKit#189, LoopKit/G7SensorKit#92), the compiler warning cleanup (LoopKit/Loop#2567, LoopKit/LoopKit#639) and real pod Bluetooth in the Simulator when a bridge is injected (loopandlearn/OmnipodKit#188).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at the next-dev build warnings: the mechanical and deprecation ones in Loop. Concurrency warnings and deprecations that can change on-screen behaviour (
NavigationLink(isActive:), implicit.animation) are left for separate PRs.Behaviour changes:
@unknown defaultand showed an empty title. It now shows its preset's name and symbol, and the switch is exhaustive.Otherwise no behaviour change:
@retroactiveon conformances of other modules' types to other modules' protocols.onChange(of:perform:),traitCollectionDidChange(nowregisterForTraitChangeswithsystemTraitsAffectingColorAppearance),HKCategoryValueSleepAnalysis.asleep,WKExtension.applicationWillResignActiveNotification.The full LoopWorkspace scheme builds, and none of these warnings remain in the edited files.