Repository navigation
Treat no pump data as no date, not the distant past - #2569
Merged
Merged
Conversation
Before a pump has ever communicated, the open-loop HUD read "Last device communication ran 739,902 days ago" to VoiceOver. With no date it reads "Waiting for first run". The bolus screen already treats a missing date as stale data.
ps2
added a commit
to LoopKit/LoopWorkspace
that referenced
this pull request
Oct 12, 2026
Brings in the VoiceOver label fixes (LoopKit/Loop#2569, LoopKit/LoopKit#640, loopandlearn/OmnipodKit#189, LoopKit/G7SensorKit#92), the compiler warning cleanup (LoopKit/Loop#2567, LoopKit/LoopKit#639) and real pod Bluetooth in the Simulator when a bridge is injected (loopandlearn/OmnipodKit#188).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before a pump has ever communicated, the open-loop HUD read "Last device
communication ran 739,902 days ago" to VoiceOver. With no date it reads
"Waiting for first run". The bolus screen already treats a missing date
as stale data.
Found by reading Loop's accessibility tree with AXe in the iOS Simulator; checked there after the change.
The open-loop HUD now reads "Last device communication ran 7 hrs ago" with a pod; the no-pump case wasn't reproduced after the change.