Repository navigation
Clean up compiler warnings that don't involve concurrency - #21
Merged
Merged
Conversation
- Remove unitDidChange(to: HKUnit), left from the HKUnit API. It was empty and never called; the protocol's default now applies. - Error messages cast the error to CustomStringConvertible, which always succeeds, so the localizedDescription fallback never ran. Use String(describing:) directly; the text is unchanged. - Mark the CGMManagerUI conformance @retroactive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
empty and never called; the protocol's default now applies.
always succeeds, so the localizedDescription fallback never ran.
Use String(describing:) directly; the text is unchanged.
Part of the next-dev build-warning cleanup (see LoopKit/Loop#2567, LoopKit/LoopKit#639). The full LoopWorkspace scheme builds, and these warnings no longer appear.