Skip to content

Clean up compiler warnings that don't involve concurrency #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ps2 merged 1 commit into from
Oct 12, 2026
Merged

Clean up compiler warnings that don't involve concurrency #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions LibreLoop/Pairing/LibreLoopCGMManager+Pairing.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,8 +1074,7 @@ extension LibreLoopCGMManager {
}
llog("reconnect: succeeded via \(outcome.path == .cached ? "cached/direct" : "full") path")
} catch {
let message = (error as? CustomStringConvertible)?.description
?? error.localizedDescription
let message = String(describing: error)
llog("reconnect: attempt failed: \(message)")
let backoff = await MainActor.run { () -> TimeInterval in
self.consecutiveReconnectFailures += 1
Expand Down
4 changes: 1 addition & 3 deletions LibreLoopUI/LibreLoopCGMManager/LibreLoopCGMManager+UI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import LoopKit
import LoopKitUI
import LibreLoop

extension LibreLoopCGMManager: CGMManagerUI {
extension LibreLoopCGMManager: @retroactive CGMManagerUI {
public static var onboardingImage: UIImage? {
UIImage(named: "FSL3-sensor", in: Bundle(for: LibreLoopSettingsViewModel.self), compatibleWith: nil)
}
Expand Down Expand Up @@ -124,8 +124,6 @@ extension LibreLoopCGMManager: CGMManagerUI {
}

public func glucoseRangeCategory(for glucose: GlucoseSampleValue) -> GlucoseRangeCategory? { nil }

public func unitDidChange(to displayGlucoseUnit: HKUnit) { }
}

private struct LibreLoopLifecycleProgress: DeviceLifecycleProgress {
Expand Down
3 changes: 1 addition & 2 deletions LibreLoopUI/Pairing/LibreLoopPairingViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ final class LibreLoopPairingViewModel: ObservableObject {
try cgmManager.applyPairingOutcome(outcome)
state = .succeeded(serial: outcome.result.sensorSerial)
} catch {
state = .failed(message: (error as? CustomStringConvertible)?.description
?? error.localizedDescription)
state = .failed(message: String(describing: error))
}
}

Expand Down