Skip to content

Console: mailbox Inbox, folded pages and readable times - #1394

Merged
JacobStephens2 merged 22 commits into
mainfrom
ui
Oct 26, 2026
Merged

JacobStephens2 merged 22 commits into
mainfrom
ui

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Closes #1368. Closes #1391. Answers part of #917 (one-line rows, full width).

Summary

The Console reads high level first: every page opens on one-line rows and folded sections, and you open what you want to see.

 Inbox
-  sections, each a capped scroll box of multi-line rows
+  folders (?section=)  │  one-line rows: state · subject · title · gist · age · Copy  │  Command details (closed until a row is chosen)
 Command details
-  every fact, nested JSON, long CLI lines wrapping
+  one line per fact, nested facts folded; CLI, Dismiss and Session trace lines on one line with Copy; file paths with a copy icon
 History, Security
-  multi-line rows; Outcome filter lists every PR and error text
+  one-line rows that open Command details; Outcome filter lists kinds: merged, ready for review, failed, plan…
 Experiments list
-  every line of every Experiment
+  headline, status line and accuracy bar
 Experiment page
+  "What it tests": Baseline vs Candidate, what changed, what "worse" means
-  Verdict, Trial grid, Arm comparison open
+  each suite folded to a one-line gist
 Stages (By repository)
+  each repository folded to its name and run count
 Waterfall
-  199 run chips
+  "Runs 199 · <run shown>" fold
 Everywhere
-  2026-10-25T17:43:26.713335520-04:00
+  2026-10-25 17:43 EDT

Other tweaks: the notifications button moves top right and its status line goes; the idle Inbox notice is trimmed and its last-fired Passes fold closed.

Console browser tests now wait 5 s, not 30 s, before failing a step (console/tests/playwright.cjs), so a broken test reports in seconds.

Evidence

  • Before: with 10 rows in Needs you, one row showed in its capped box. Command details for a Security run took several screens. Times were raw RFC 3339. The History Outcome list on a real machine had 70+ entries, one per PR or error.
    After: tried against copies of two real machines' records:
    • every Needs you row shows on one line;
    • Command details fits in one screen and its facts unfold on demand;
    • History offers 8 outcome kinds (merged shows 235 runs, failed 125).
  • Tests, written first where behavior changed:
    • cargo test --test console: 118 passed. New tests cover the row gist, folded Command details, local minutes, the "What it tests" section and outcome kinds.
    • npm test --prefix console on Linux (stephens.page): all 96 passed, including the Linux-only live-process tests.
    • On macOS: 76 passed, 19 skipped as Linux-only, 1 failed. The failure is Stages handles invalid or unavailable preferences…, a macOS-only problem filed as Stages preferences browser test changes the View selector with a key macOS Chromium ignores #1395. The suite runs in 24 s.
    • npm test --prefix site: 50 passed.
    • cargo test --bin thirdshift:
      • Six timing and sandbox tests fail under full-suite load and pass when run alone.
      • worktree::synchronization_tests::*shadowing* fails because of this machine's git tag config; this branch does not touch src/worktree.

Merge Danger

Door: two-way

Templates, CSS, JS and display formatting only. Command records, the CLI and JSON output are unchanged. The History filter still accepts an exact outcome text in older ?outcome= links.

Blast Radius: Console-layout

Layout changes reach every Console page and every built-in Theme. Things that were visible on load are now one click away. j/k moves through one-line rows and their Command details. Without JavaScript, rows show in full, and folds are plain <details> that open with a click.

The button already says whether notifications are on. The status line now
speaks only when notifications are unavailable or fail.
The Inbox and status warning read 2026-10-26 06:23 EDT instead of an RFC 3339
UTC stamp. status --json keeps github_last_answered_at as RFC 3339.
Each Inbox section is a folder beside the list, chosen by ?section= so it
works without JavaScript and survives reloads; the server still renders every
section and hides the others, so a folder opens in place and Back and Forward
return to it. Rows are one line each and the list never scrolls inside
itself, replacing the 96-300px cap that showed one of ten Needs you rows. On a
wide screen Command details stay open beside the list for the selected row and
follow j and k. Phones get folder tabs and the bottom sheet. Without
JavaScript, rows still show in full with their own Dismiss.
With many repositories the list pushed the rows below the fold. It now sits
under Last fired Passes, beside Last recorded skipped Passes.
Details open when a row is clicked or Space is pressed, then follow j, k and
folder switches until closed.
Drop the Needs you pointer, which the folder and its count already give, and
the Cron jobs and scheduler advice.
Title-less Pass rows show the issue they dispatched, their first finding
or their cause after the outcome.
#1367's Copy button sat in the row actions, which one-line rows hide; it now
ends each Needs you line, and the copied text leaves out the line's gist.
Dismiss, its command and a Copy CLI share one row; long paths are cut off,
Session traces from the start so their distinguishing ends show.
Long values and nested facts start closed behind a one-line preview and keep
their folds through a live refresh of the same Command; Session traces fold
into a count; file paths keep their end on one line with a copy icon.
The page leads with the Candidate's changes from the Baseline, the suites it
is judged on and the Bar's margin; matching arms say the Experiment tests no
change and only shows run-to-run variation.
One formatter, moved from the GitHub warning to local_time, rewrites RFC 3339
instants in Console text, such as Command details, finish labels, Stages
headers, Experiment times and quoted causes, as 2026-10-25 17:43 EDT. Records,
CLI output and Session traces keep full instants.
@JacobStephens2
JacobStephens2 merged commit 730db7c into main Oct 26, 2026
9 checks passed
@JacobStephens2
JacobStephens2 deleted the ui branch October 26, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant