Skip to content

Add Copy to Needs you Console rows - #1367

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-1365
Oct 26, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-1365

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

Each Needs you row can copy its problem facts, child Commands, absolute links and equivalent CLI command for sharing with an agent.

Needs you → Copy → snapshot of rendered facts
  clipboard available → Copied. (survives live refresh)
  clipboard unavailable → selected text in a dialog

The dialog preserves its snapshot through live updates and supports keyboard copying on phones. Console and site documentation describe the workflow.

Closes #1365

Evidence

  • Before: node --test --test-name-pattern='Needs you copies' console/tests/inbox.test.cjs failed after a live record update: '' !== 'Copied.'.
    After: the regression passes; Copy confirmation survives refresh. The test owns its Command fixture so earlier tests cannot change its expected title.
  • node --test console/tests/inbox.test.cjs: 42 passed, including clipboard success, refused/unavailable clipboard, selection across live updates, keyboard access and 390 px layout.
  • cargo build --locked, cargo fmt -- --check and git diff --check: passed.
  • Linux CI on f0f83e3a: 3,092 Rust tests passed, 69 skipped; 785.336s test execution plus 50.78s compilation. Formatting and Clippy also passed.
  • /usr/bin/time -p scripts/affected-tests main: all 50 site tests passed. Cancelled the duplicate local Rust run after exact-head CI passed, following docs/testing.md's reuse policy. Local selector elapsed: 1159.82s, including compilation and the partial Rust run.
  • CI's complete Console browser, site, macOS gate and release workflows passed.

Test seams

  • Served Console controls and the browser clipboard/manual selection, using fixture Command records and real live updates.

Review coverage

Independent Standards and Spec reviews against main, including the final refresh fix: 0 findings on each axis. Both reviewers read all nine changed files. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

  • Standards: none.
  • Spec: none.
  • Security: none. Guidance-mode review of the Needs you Copy change (no full audit, no validators): no introduced findings. Copy path uses text-only sinks (clipboard.writeText/textarea.value, no innerHTML-style sink in console.js), strips forms carrying the CSRF token before reading textContent, relies on Askama/linkify escaping (https-only links), and single-quote-escapes the selector for the pasted shell line; a local node PoC round-tripped 7 adversarial selectors through /bin/sh as single words with no breakout. No failing PoC, so no fix and no pre-existing entries.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert the change to remove the Copy controls; no persisted-data changes.

Blast Radius: Console

Needs you row rendering and browser copy feedback; no GitHub writes or Command state changes.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit be154d7 into main Oct 26, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1365 branch October 26, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add copy button to needs you section of console web ui for easy copying of relevant information to share with an agent

1 participant