Skip to content

Console: fold the Logs page by repository; fix the macOS Stages test - #1400

Merged
JacobStephens2 merged 3 commits into
mainfrom
console-folds
Oct 26, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
console-folds

Conversation

@JacobStephens2

Copy link
Copy Markdown
Owner

Closes #1395. Follows #1394's folding principle on the one Console page it left open.

Summary

 Logs page
-  <ul class="log-list"> every log from every repository
+  <details class="group log-group" data-repository="owner/repo" [open if only one]>
+    <summary>owner/repo · N logs · M live</summary>
+    <ul class="log-list"> that repository's logs
  • Groups keep the catalog's order; a single repository (e.g. /logs/command/<id>) opens straight away, as Stages does.
  • Keyboard follows the Inbox sections: j/k step through repositories and logs, Space toggles, z folds, Enter on a folded repository opens its first log.

The Stages preferences browser test set the View with ArrowDown then Enter, which a closed <select> ignores in Chromium on macOS, so it failed on every Mac. It now uses selectOption and still checks focus and value survive a live update.

Evidence

  • Before: macOS npm test --prefix console: 76 passed, 1 failed (Stages handles invalid or unavailable preferences…).
    After: 77 passed, 0 failed, 19 skipped as Linux-only.
  • Linux (stephens.page): all 96 browser tests pass, including the Linux-only Logs tests.
  • New logs_fold_by_repository_unless_there_is_only_one:
    one repository   -> <details … data-repository="acme/widgets" open>
    two repositories -> each folded, summary "aaa/first 1 log", "acme/widgets 2 logs", rows inside
    
    cargo test --test console: 119 passed.

Merge Danger

Door: two-way

Template, CSS and one keyboard selector; thirdshift logs --json and the reader pages are unchanged.

Blast Radius: Logs-page

A Logs page with several repositories now opens folded: one click (or Space) to see a repository's logs.

@JacobStephens2
JacobStephens2 merged commit 0933f8a into main Oct 26, 2026
24 of 25 checks passed
@JacobStephens2
JacobStephens2 deleted the console-folds branch October 26, 2026 18:46
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stages preferences browser test changes the View selector with a key macOS Chromium ignores

1 participant