Repository navigation
Console: fold the Logs page by repository; fix the macOS Stages test - #1400
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1395. Follows #1394's folding principle on the one Console page it left open.
Summary
/logs/command/<id>) opens straight away, as Stages does.zfolds, Enter on a folded repository opens its first log.The Stages preferences browser test set the View with ArrowDown then Enter, which a closed
<select>ignores in Chromium on macOS, so it failed on every Mac. It now usesselectOptionand still checks focus and value survive a live update.Evidence
npm test --prefix console: 76 passed, 1 failed (Stages handles invalid or unavailable preferences…).After: 77 passed, 0 failed, 19 skipped as Linux-only.
logs_fold_by_repository_unless_there_is_only_one:cargo test --test console: 119 passed.Merge Danger
Door: two-way
Template, CSS and one keyboard selector;
thirdshift logs --jsonand the reader pages are unchanged.Blast Radius: Logs-page
A Logs page with several repositories now opens folded: one click (or Space) to see a repository's logs.