Repository navigation
Save Claude setup tokens in Credentials on main - #1170
Merged
Merged
Conversation
Cherry-pick of #1125 (ea53fba), which merged into issue-977, so the setup token can ship before the rest of #977. Conflicts in GLOSSARY.md, docs/guide.md, site/docs/index.html, site/how-it-works/index.html and src/setup.rs came from main's plain-names wording (#1148); each keeps main's Ticket run wording and #1125's content.
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings #1125's Claude setup token in the Credentials to
main, so it can ship in 0.14.5 without the rest of #977. #1125 merged intoissue-977, which also carries an unsandboxedthirdshift experiment(#1012-#1015 are still open).Conflicts were only wording:
main's plain names (#1148) against #1125's token text, inGLOSSARY.md,docs/guide.md,site/docs/index.html,site/how-it-works/index.htmlandsrc/setup.rs's expected prompts. Each keeps Ticket run and #1125's content.Unblocks the last step of #1011: save the token through Setup on the
thirdshifthost.Evidence
v0.14.4has noclaude.setup_token;git grep -il setup_token v0.14.4 -- srcfinds nothing, and Setup never asks for a token.After: Save Claude setup tokens in Credentials #1125's six tests pass on
main, among thema_claude_setup_token_is_saved_with_hidden_input_even_without_notifications,malformed_credentials_never_echo_the_claude_setup_tokenandordinary_runs_never_use_or_record_the_saved_claude_setup_token.cargo fmt --check,cargo clippy --all-targets -- -D warningsand the fullcargo testpassed locally: 60 of 60 test binaries ok, 0 failed.Merge Danger
Door: two-way
When
issue-977later merges intomain, git sees #1125's change on both sides; expect at most these same five files to need the same wording resolution.Blast Radius: Setup
The strict Credentials schema also serves email commands. A
credentials.tomlwith a[claude]section is rejected as an unknown section by 0.14.4 and earlier, so don't downgrade after saving a token.