Repository navigation
Spec: Plain names, from the Ticket run to the homepage - #1148
Merged
Merged
Conversation
Use Ticket run names throughout agent-facing documentation
Use Ticket run labels in output and the Console
Use plain Ticket run names and five workflows on the site
JacobStephens2
marked this pull request as ready for review
October 23, 2026 14:15
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies Spec #1101 across the glossary, manual, Session prompts, Factory skills, CLI output, notifications, GitHub comments and Console, then the homepage, How it works, Architecture and share card. Self-merge is an option of a Ticket run. Former-name notes and README bookmark forwarding preserve navigation; dated records, the recorded replay and the colophon's story remain intact.
ADR 0022 records the compatibility split: stored kinds, Activity log values and JSON retain
Run; human displays sayTicket run. The whole-Spec review also corrects span JSON compatibility and the homepage's accessible labels.Closes #1101
Evidence
cargo test --test console span_json_retains_stable_run_and_dispatch_namesfailed because span JSON emittedTicket run · acme/widgets#7 · Widgetsinstead ofRun · acme/widgets#7 · Widgets.After: passes with stable JSON names and new human-readable CLI/Console names.
site/,node --test --test-name-pattern='homepage accessible names use steps' tests/pages.test.cjsfailed (0 !== 1) because screen-reader labels still named press units.After: passes with Ticket run steps, step 1–4 and the selected step's replay.
cargo test --bin thirdshift prompts_page: 12 passed.npm test --prefix console: 59 passed.cargo fmt --check: passed.scripts/affected-tests mainpassed all 49 site checks and ran Rust tests throughsite_deploy, where the host's enabledsnapd.servicecaused an unrelated systemd warning. That invocation exited nonzero after 1090.77 seconds, with cached Rust compilation. The focused deployment-unit test passed withSYSTEMD_UNIT_PATH=/usr/lib/systemd/system. The seven remaining Cargo test targets then passed in 257.75 seconds. Together these runs cover the binary unit tests and all 56 integration targets; no selected test remains unverified.Host-only validation adjustments: put
/home/jstephens/.cargo/binonPATH; useGIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=falseto prevent the host's signed-tag setting opening fixture editors. The systemd override limits verification to vendor unit dependencies. No repository or global configuration was changed for these adjustments.Regression seams: the public
show --spans,show --span --jsonandshow --spans --jsonCLI interfaces; the Console Waterfall browser display; the homepage's accessible names.Review coverage
Standards and Spec independently inspected all 81 changed files, including generated output and the share-card image, with a follow-up on the final fixes. Changed files left unread: none. Generated-output exclusions: none. Final reports are retained in this session's
.thirdshift-review-kz9EwD/standards.mdandspec.md.Unaddressed findings
Standards
None.
Spec
src/console/assets/spans.js:184–189, introduced by9c435ca, which measures the settled row and scrolls again to keep it between the sticky axis and phone Peek sheet. Spec Spec: Plain names, from the Ticket run to the homepage #1101 explicitly excludes behavior changes, so the scope finding is valid; it is not a broken-behavior claim. Fromconsole/,node --test --test-name-pattern='span tree, summary Peek, zoom and keyboard work at laptop and 390 px' tests/spans.test.cjspasses, including row visibility at 390 px. That run supports retaining the working fix but does not settle scope. #1156, labelled onlyneeds-triage, asks the Day shift whether to include or separate it. The reviewer cannot expand the rename-only Spec.The other two Spec findings were reproduced and fixed with retained regression tests.
Merge Danger
Door: two-way
Text and presentation changes can be reverted; stored records and JSON keep their existing values.
Blast Radius: presentation
Documentation, CLI/Console labels, notifications and site copy. The retained phone Peek adjustment also changes scroll positioning, tracked in #1156.
Built with codex · gpt-6.1-sol · high
Tickets