Skip to content

Spec: Plain names, from the Ticket run to the homepage - #1148

Merged
JacobStephens2 merged 14 commits into
mainfrom
issue-1101
Oct 23, 2026
Merged

JacobStephens2 merged 14 commits into
mainfrom
issue-1101

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

- Run / Merge run / Failed run
+ Ticket run / Ticket run with Self-merge / Failed ticket run
- Weeding / Fencing
+ Architect runs every few minutes / Security runs on a schedule, with fixing allowed
- Six workflows and print-shop labels
+ Five workflows, plain steps, and an opening that explains your logged-in agents and their usage plans

Applies Spec #1101 across the glossary, manual, Session prompts, Factory skills, CLI output, notifications, GitHub comments and Console, then the homepage, How it works, Architecture and share card. Self-merge is an option of a Ticket run. Former-name notes and README bookmark forwarding preserve navigation; dated records, the recorded replay and the colophon's story remain intact.

ADR 0022 records the compatibility split: stored kinds, Activity log values and JSON retain Run; human displays say Ticket run. The whole-Spec review also corrects span JSON compatibility and the homepage's accessible labels.

Closes #1101

Evidence

  • Before: cargo test --test console span_json_retains_stable_run_and_dispatch_names failed because span JSON emitted Ticket run · acme/widgets#7 · Widgets instead of Run · acme/widgets#7 · Widgets.
    After: passes with stable JSON names and new human-readable CLI/Console names.
  • Before: from site/, node --test --test-name-pattern='homepage accessible names use steps' tests/pages.test.cjs failed (0 !== 1) because screen-reader labels still named press units.
    After: passes with Ticket run steps, step 1–4 and the selected step's replay.
  • cargo test --bin thirdshift prompts_page: 12 passed. npm test --prefix console: 59 passed. cargo fmt --check: passed.
  • scripts/affected-tests main passed all 49 site checks and ran Rust tests through site_deploy, where the host's enabled snapd.service caused an unrelated systemd warning. That invocation exited nonzero after 1090.77 seconds, with cached Rust compilation. The focused deployment-unit test passed with SYSTEMD_UNIT_PATH=/usr/lib/systemd/system. The seven remaining Cargo test targets then passed in 257.75 seconds. Together these runs cover the binary unit tests and all 56 integration targets; no selected test remains unverified.

Host-only validation adjustments: put /home/jstephens/.cargo/bin on PATH; use GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=false to prevent the host's signed-tag setting opening fixture editors. The systemd override limits verification to vendor unit dependencies. No repository or global configuration was changed for these adjustments.

Regression seams: the public show --spans, show --span --json and show --spans --json CLI interfaces; the Console Waterfall browser display; the homepage's accessible names.

Review coverage

Standards and Spec independently inspected all 81 changed files, including generated output and the share-card image, with a follow-up on the final fixes. Changed files left unread: none. Generated-output exclusions: none. Final reports are retained in this session's .thirdshift-review-kz9EwD/standards.md and spec.md.

Unaddressed findings

Standards

None.

Spec

  • P2 scope judgment: phone Peek positioning. Retained src/console/assets/spans.js:184–189, introduced by 9c435ca, which measures the settled row and scrolls again to keep it between the sticky axis and phone Peek sheet. Spec Spec: Plain names, from the Ticket run to the homepage #1101 explicitly excludes behavior changes, so the scope finding is valid; it is not a broken-behavior claim. From console/, node --test --test-name-pattern='span tree, summary Peek, zoom and keyboard work at laptop and 390 px' tests/spans.test.cjs passes, including row visibility at 390 px. That run supports retaining the working fix but does not settle scope. #1156, labelled only needs-triage, asks the Day shift whether to include or separate it. The reviewer cannot expand the rename-only Spec.

The other two Spec findings were reproduced and fixed with retained regression tests.

Merge Danger

Door: two-way

Text and presentation changes can be reverted; stored records and JSON keep their existing values.

Blast Radius: presentation

Documentation, CLI/Console labels, notifications and site copy. The retained phone Peek adjustment also changes scroll positioning, tracked in #1156.

Built with codex · gpt-6.1-sol · high

Tickets

@JacobStephens2
JacobStephens2 marked this pull request as ready for review October 23, 2026 14:15
@JacobStephens2
JacobStephens2 merged commit 3c53d52 into main Oct 23, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1101 branch October 23, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec: Plain names, from the Ticket run to the homepage

1 participant