Skip to content

Use Ticket run labels in output and the Console - #1149

Merged
JacobStephens2 merged 5 commits into
issue-1101from
issue-1103
Oct 23, 2026
Merged

JacobStephens2 merged 5 commits into
issue-1101from
issue-1103

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

stored Run / dispatched Run
  → CLI and Console: Ticket run / dispatched Ticket run
  → records, Activity log and JSON: existing values

Update Setup questions and generated User config comments, notifications, GitHub closing comments and Base fix text, failure-preservation commits, and quoted manual output. Regenerate /docs/. Keep a selected Waterfall span visible when scrolling pins the sticky axis above the phone Peek.

Closes #1103

Evidence

  • Before: cargo test --test status ticket_run_display_preserves_the_stored_command_kind failed on the displayed Run label.
    After: passes; also checks status --json retains Run, show displays Ticket run, and the retained record is unchanged. Legacy Activity-log fixtures retain their original values.
  • Before: the reviewer's exact cargo test --test security_run status_tracks_security_stages_and_nests_the_dispatched_fix -- --exact failed on an old visible dispatch expectation.
    After: passes (1 passed, 0 failed); the test remains in place with the new visible expectation.
  • Before: the isolated span browser test hid four pixels of the selected row behind the phone Peek after the axis became sticky.
    After: node --test --test-name-pattern='span tree, summary Peek, zoom and keyboard' console/tests/spans.test.cjs passes with the original geometry assertions.
  • cargo check and cargo fmt --check pass. Site browser suite: 45 passed. Console browser suite: 59 passed.
  • Full validation also caught a multiline Setup expectation and an Architect dispatch expectation. Both exact targeted tests now pass, with their original behavior checks retained.
  • Full Rust CI suite: cargo test passed on final head f351fc8 in 12m 8s, including compilation. Clippy, formatting, site, Console and build checks are green too.
  • Local scripts/affected-tests issue-1101 passed the 45 site tests, 1,243 unit tests and subsequent integration suites through Security review without failures. Its duplicate full Rust run was stopped by task ID once exact-head CI passed, reusing that result under docs/testing.md. The local run disabled global tag signing only for its git fixtures; its full-suite wall time is therefore incomplete.

Test seams

  • CLI status/show over retained Command records and legacy Activity logs, including JSON compatibility.
  • CLI output and Setup through existing executable scenarios and terminal fixtures.
  • Run notification subject/body and GitHub text through existing public behavior tests.
  • Console HTTP pages and Playwright browser views over stored fixture records.

Review coverage

Standards and Spec independently reviewed git diff issue-1101...HEAD from fixed point 380e63aad00d0b17420282eaff0e39d312c6a97c, followed by the repair diff. Both read 74 of the final 75 changed files, including generated output. Generated exclusions: none.

Changed file left unread by both independent reviewers: tests/architect_run.rs. It was changed after their one coverage follow-up. The full test run reproduced its stale visible Run expectation; the root inspected it, preserved the stored/JSON Run assertion, updated the visible expectation, and ran cargo test --test architect_run status_nests_the_architect_plans_run_or_spec_run_under_its_pass -- --exact successfully (1 passed, 0 failed).

Addressed the Standards finding by distinguishing Ticket runs from Spec runs in the Security review manual. Addressed the Spec finding by updating visible dispatch assertions while keeping the fixture and JSON values stable.

Unaddressed findings

Standards

None.

Spec

None.

Merge Danger

Door: two-way

Blast Radius: presentation

Stored kinds, dispatch stage values, log paths and identifiers retain their existing names. The Waterfall scroll adjustment affects selection visibility only.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 4113afb into issue-1101 Oct 23, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1103 branch October 23, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant