Repository navigation
Use Ticket run labels in output and the Console - #1149
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Setup questions and generated User config comments, notifications, GitHub closing comments and Base fix text, failure-preservation commits, and quoted manual output. Regenerate
/docs/. Keep a selected Waterfall span visible when scrolling pins the sticky axis above the phone Peek.Closes #1103
Evidence
cargo test --test status ticket_run_display_preserves_the_stored_command_kindfailed on the displayedRunlabel.After: passes; also checks
status --jsonretainsRun,showdisplaysTicket run, and the retained record is unchanged. Legacy Activity-log fixtures retain their original values.cargo test --test security_run status_tracks_security_stages_and_nests_the_dispatched_fix -- --exactfailed on an old visible dispatch expectation.After: passes (1 passed, 0 failed); the test remains in place with the new visible expectation.
After:
node --test --test-name-pattern='span tree, summary Peek, zoom and keyboard' console/tests/spans.test.cjspasses with the original geometry assertions.cargo checkandcargo fmt --checkpass. Site browser suite: 45 passed. Console browser suite: 59 passed.cargo testpassed on final headf351fc8in 12m 8s, including compilation. Clippy, formatting, site, Console and build checks are green too.scripts/affected-tests issue-1101passed the 45 site tests, 1,243 unit tests and subsequent integration suites through Security review without failures. Its duplicate full Rust run was stopped by task ID once exact-head CI passed, reusing that result underdocs/testing.md. The local run disabled global tag signing only for its git fixtures; its full-suite wall time is therefore incomplete.Test seams
Review coverage
Standards and Spec independently reviewed
git diff issue-1101...HEADfrom fixed point380e63aad00d0b17420282eaff0e39d312c6a97c, followed by the repair diff. Both read 74 of the final 75 changed files, including generated output. Generated exclusions: none.Changed file left unread by both independent reviewers:
tests/architect_run.rs. It was changed after their one coverage follow-up. The full test run reproduced its stale visibleRunexpectation; the root inspected it, preserved the stored/JSONRunassertion, updated the visible expectation, and rancargo test --test architect_run status_nests_the_architect_plans_run_or_spec_run_under_its_pass -- --exactsuccessfully (1 passed, 0 failed).Addressed the Standards finding by distinguishing Ticket runs from Spec runs in the Security review manual. Addressed the Spec finding by updating visible dispatch assertions while keeping the fixture and JSON values stable.
Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Blast Radius: presentation
Stored kinds, dispatch stage values, log paths and identifiers retain their existing names. The Waterfall scroll adjustment affects selection visibility only.
Built with codex · gpt-6.1-sol · high