Repository navigation
Save Claude setup tokens in Credentials - #1125
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setup offers hidden token input independently of email, preserves saved secrets and comments, and saves Credentials with mode 0600. Malformed TOML diagnostics hide file contents. Ordinary Runs keep their existing login; #1012 supplies the token to Trials.
Closes #1010
Test seams
setupon a real terminal: hidden input, persistence, permissions, retention and interruption.email-test: strict shared Credentials parsing and secret-free diagnostics.Evidence
cargo test --test email_test a_claude_setup_token_can_share_the_credentials_without_being_sent_or_printedfailed withunknown section [claude]; the terminal token test failed because Setup never asked for it;malformed_credentials_never_echo_the_claude_setup_tokenreproduced a token leak in parse diagnostics.After: all three pass. Terminal coverage also checks retention/replacement alongside the Resend key, comments, mode 0600 and interruption. An ordinary Run test checks its Harness environment, output, logs and Command record for token isolation.
cargo check --all-targets,cargo clippy --all-targets -- -D warningsandcargo fmt --checkpassed./usr/bin/time -p scripts/affected-tests e6c92e19cfbe8352a1e8ca18eab8107dc49b870b: all 43 site tests passed; the initial Rust run stopped on three Setup fixtures missing the new prompt (909.08s total, including compilation and site checks). Those fixtures and the corresponding first-Run fixture are corrected. Focused reruns passed: Console Setup 10, Muse Setup 1, OpenCode Setup 2, first-Run Setup 8.92bb37d: 2,422 Rust tests passed, 57 ignored, plus site and Console browser checks. The Linux job took 13m 09s including setup and compilation. This successful exact-head CI supplies the final full-suite evidence.Unaddressed findings
Answers::credential_editsand independently rechecked.Review coverage
Both independent axes read all 14 changed files, including the generated manual and updated Setup fixtures. Unread changed files: none. Generated-output exclusions: none. Review fixed point:
issue-977ate6c92e1.Merge Danger
Door: two-way
Blast Radius: Setup
The strict Credentials schema also serves email commands. Resend environment precedence remains covered; new sections are incompatible with older thirdshift versions that reject unknown keys.
Built with codex · gpt-6.1-sol · xhigh