Skip to content

Fix dashboard panel dragging and show request loading - #16

Open
akshay-ghl wants to merge 2 commits into
recover/sep18-custom43-integratedfrom
deploy/dashboard-interactions-stg
Open

akshay-ghl wants to merge 2 commits into
recover/sep18-custom43-integratedfrom
deploy/dashboard-interactions-stg

Conversation

@akshay-ghl

Copy link
Copy Markdown

Restore dashboard dragging from shared chart headers and show an accessible loading indicator during active requests, including time-range changes that retain previous results. Chart bodies, controls and portals remain excluded from dragging; existing read-only restrictions are preserved.

This release is based on the currently deployed custom.59 application source (df735137), retaining Min/Max/Last legends and the Node 22.23.4 security update. It does not merge the broader recovery branch into stg.

Validation: 54 focused tests, TypeScript and staged-file ESLint/Prettier pass on the release candidate. The earlier full suite had 59 failures reproduced on its unchanged baseline; repository-wide lint/Knip also have existing unrelated findings. Global Git hooks override the repository Husky path, so staged-file checks were explicitly run. Image build and US Central staging rollout evidence will be recorded in the Helm deployment PR.

After deployment, verify panel header dragging and saved position after reload, protected chart/menu interactions, read-only behavior, and visible loading during a time-range change.

vallurureddy-hl and others added 2 commits October 27, 2026 06:47
Pick up the October 2026 Node.js security release:
- docker/hyperdx/Dockerfile: ARG NODE_VERSION 22.22 -> 22.23.4
- packages/api/Dockerfile, packages/app/Dockerfile: node:22.16.0-alpine -> node:22.23.4-alpine
- .nvmrc: 22.23.1 -> 22.23.4

Co-Authored-By: AW <273421570+ghl-aw@users.noreply.github.com>

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@code-quality-gates

Copy link
Copy Markdown

⛔ This PR is blocked

1 critical check(s) failed. Critical gates enforce security & compliance — the PR cannot merge until they pass. Each failing gate and how to fix it is listed below.


Quality Gate Results

⛔ 1 Critical failed — blocking
⚠️ 3 Warning(s) — non-blocking, please review
✅ 8 Passed

❌ Must fix before merging

hardcoded_api_keys (repo-wide check — may flag existing code outside your changes)

  • docker/otel-collector/custom.config.yaml:55 — Found potential Hardcoded auth/access token
  • packages/api/openapi.json:5006 — Found potential Slack Webhook URL
  • packages/api/openapi.json:5232 — Found potential Slack Webhook URL
  • packages/api/src/routers/api/__tests__/webhooks.int.test.ts:13 — Found potential Slack Webhook URL
  • packages/api/src/routers/api/__tests__/webhooks.int.test.ts:636 — Found potential Slack Webhook URL
  • …and 22 more (see detailed results)
  • ✅ How to fix: Remove this key and replace it with a reference from the secrets manager.
  • 📖 Full docs & exception process

⚠️ Warnings (non-blocking — worth reviewing)

  • block_clickhouse_client_create_client_usage (8 items) — detailed results (inline comments only on changed lines) · 📖 docs
  • dependency_license_check (1 item) — detailed results (inline comments only on changed lines) · 📖 docs
  • production_sidecar_verification_check (1 item) — detailed results (inline comments only on changed lines) · 📖 docs

🔍 View detailed quality gate results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants