Skip to content

Make dashboard panel actions accessible by keyboard for staging - #18

Open
akshay-ghl wants to merge 1 commit into
deploy/dashboard-interactions-stgfrom
ai/stg-panel-action-accessibility
Open

akshay-ghl wants to merge 1 commit into
deploy/dashboard-interactions-stgfrom
ai/stg-panel-action-accessibility

Conversation

@akshay-ghl

Copy link
Copy Markdown

Dashboard panel controls now have accessible names before hover and show their tooltips on keyboard focus. The compact menu is consistently named “Panel actions”; chart display buttons expose their selected state. Existing callbacks, permissions, disabled modes and drag exclusions are preserved.

Adapts the discoverable panel controls in the inspected Grafana time-series demo. Changes stay with their existing owners: dashboard toolbar, shared ChartContainer compact menu and shared DisplaySwitcher. No layout redesign, dependencies or global tooltip defaults.

Staging dependency: targets deploy/dashboard-interactions-stg, the source of deployed custom.60 (cee727a8, PR #16). The source stg branch lacks that recovered UI baseline. This is a focused stacked PR for US Central staging; do not merge/deploy the broader recovery work as part of this PR.

Validation:

  • 7 focused tests pass: accessible menu and display states, keyboard activation, disabled modes, chart-header drag protection, and single/multiple-move persistence callbacks.
  • App TypeScript and changed-file ESLint pass (existing dashboard warnings remain).
  • Native Chrome local preview: Tab reveals the compact-menu tooltip; Enter/Down/Enter activates its action; keyboard display switching updates the pressed state. Independent source and screenshot review found no blockers. Theme screenshots are local shared-component evidence, not staging screenshots.
  • Repository-wide yarn lint:fix fails on the existing restricted import in SQLInlineEditor.commentCommand.test.ts; unrelated formatting was excluded.

Limits: the wide dashboard toolbar was source-checked, not exercised in an authenticated full-page preview. Full consumer-page integration, screen-reader testing, measured contrast, production-image build and live staging validation remain pending. No Helm/image/deployment changes. Existing Min/Max/Last legends are unchanged.

Follow-up proposals, not included: panel links retaining investigation context; per-panel refresh/error feedback. The companion time-picker PR adds explicit time context and preset search.

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@code-quality-gates

Copy link
Copy Markdown

⛔ This PR is blocked

1 critical check(s) failed. Critical gates enforce security & compliance — the PR cannot merge until they pass. Each failing gate and how to fix it is listed below.


Quality Gate Results

⛔ 1 Critical failed — blocking
⚠️ 3 Warning(s) — non-blocking, please review
✅ 8 Passed

❌ Must fix before merging

hardcoded_api_keys (repo-wide check — may flag existing code outside your changes)

  • docker/otel-collector/custom.config.yaml:55 — Found potential Hardcoded auth/access token
  • packages/api/openapi.json:5006 — Found potential Slack Webhook URL
  • packages/api/openapi.json:5232 — Found potential Slack Webhook URL
  • packages/api/src/routers/api/__tests__/webhooks.int.test.ts:13 — Found potential Slack Webhook URL
  • packages/api/src/routers/api/__tests__/webhooks.int.test.ts:636 — Found potential Slack Webhook URL
  • …and 22 more (see detailed results)
  • ✅ How to fix: Remove this key and replace it with a reference from the secrets manager.
  • 📖 Full docs & exception process

⚠️ Warnings (non-blocking — worth reviewing)

  • block_clickhouse_client_create_client_usage (8 items) — detailed results (inline comments only on changed lines) · 📖 docs
  • dependency_license_check (1 item) — detailed results (inline comments only on changed lines) · 📖 docs
  • production_sidecar_verification_check (1 item) — detailed results (inline comments only on changed lines) · 📖 docs

🔍 View detailed quality gate results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant