Repository navigation
Make dashboard panel actions accessible by keyboard for staging - #18
Open
akshay-ghl wants to merge 1 commit into
Open
akshay-ghl wants to merge 1 commit into
akshay-ghl wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
⛔ This PR is blocked1 critical check(s) failed. Critical gates enforce security & compliance — the PR cannot merge until they pass. Each failing gate and how to fix it is listed below. Quality Gate Results⛔ 1 Critical failed — blocking ❌ Must fix before merging
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard panel controls now have accessible names before hover and show their tooltips on keyboard focus. The compact menu is consistently named “Panel actions”; chart display buttons expose their selected state. Existing callbacks, permissions, disabled modes and drag exclusions are preserved.
Adapts the discoverable panel controls in the inspected Grafana time-series demo. Changes stay with their existing owners: dashboard toolbar, shared
ChartContainercompact menu and sharedDisplaySwitcher. No layout redesign, dependencies or global tooltip defaults.Staging dependency: targets
deploy/dashboard-interactions-stg, the source of deployed custom.60 (cee727a8, PR #16). The sourcestgbranch lacks that recovered UI baseline. This is a focused stacked PR for US Central staging; do not merge/deploy the broader recovery work as part of this PR.Validation:
yarn lint:fixfails on the existing restricted import inSQLInlineEditor.commentCommand.test.ts; unrelated formatting was excluded.Limits: the wide dashboard toolbar was source-checked, not exercised in an authenticated full-page preview. Full consumer-page integration, screen-reader testing, measured contrast, production-image build and live staging validation remain pending. No Helm/image/deployment changes. Existing Min/Max/Last legends are unchanged.
Follow-up proposals, not included: panel links retaining investigation context; per-panel refresh/error feedback. The companion time-picker PR adds explicit time context and preset search.