Skip to content

Improve time-picker context and preset search for staging - #17

Open
akshay-ghl wants to merge 1 commit into
deploy/dashboard-interactions-stgfrom
ai/stg-time-picker-context
Open

akshay-ghl wants to merge 1 commit into
deploy/dashboard-interactions-stgfrom
ai/stg-time-picker-context

Conversation

@akshay-ghl

Copy link
Copy Markdown

The shared time picker now shows the input timezone, full timestamps with offsets, and elapsed duration. Search narrows the existing presets without submitting a query; clearing by keyboard retains focus and cannot trigger the global Apply shortcut.

Inspired by Grafana time controls and the inspected official time-series demo. Reuses HyperDX's parser, preferences, Mantine controls and theme tokens. No dependencies, APIs, retention changes or query behavior changes.

Staging dependency: targets deploy/dashboard-interactions-stg, the source of deployed custom.60 (cee727a8, PR #16). The source stg branch lacks that recovered UI baseline. This is a focused stacked PR for US Central staging, not a request to merge the broader recovery PR or deploy automatically.

Validation:

  • 39 time-picker tests pass, including filtering, keyboard clear, dismissal, existing monitoring presets, invalid input, and a 23-hour DST range. The new keyboard regression failed before the fix.
  • App TypeScript and changed-file ESLint pass (one existing array-index warning).
  • Native Chrome local preview: search/clear Enter leave the query counter at zero; UTC/browser context and full range remain readable. Four brand/color combinations inspected; independent source and screenshot review found no remaining blockers.
  • Repository-wide yarn lint:fix fails on the existing restricted import in SQLInlineEditor.commentCommand.test.ts; unrelated formatting was excluded.

Limits: preview describes the outer input, not unsaved calendar fields or fetched results. Relative previews resolve on open, not continuously; unparseable input, including Live Tail, shows timezone without inventing timestamps. Local evidence uses actual shared components with synthetic data. Full authenticated consumer-page checks, screen-reader testing, production-image build and live staging validation remain pending. No Helm/image/deployment changes.

Follow-up proposals, not included: recent absolute ranges; copying investigation context; per-panel refresh/error feedback. Existing Min/Max/Last legends are unchanged.

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@code-quality-gates

Copy link
Copy Markdown

⛔ This PR is blocked

1 critical check(s) failed. Critical gates enforce security & compliance — the PR cannot merge until they pass. Each failing gate and how to fix it is listed below.


Quality Gate Results

⛔ 1 Critical failed — blocking
⚠️ 3 Warning(s) — non-blocking, please review
✅ 8 Passed

❌ Must fix before merging

hardcoded_api_keys (repo-wide check — may flag existing code outside your changes)

  • docker/otel-collector/custom.config.yaml:55 — Found potential Hardcoded auth/access token
  • packages/api/openapi.json:5006 — Found potential Slack Webhook URL
  • packages/api/openapi.json:5232 — Found potential Slack Webhook URL
  • packages/api/src/routers/api/__tests__/webhooks.int.test.ts:13 — Found potential Slack Webhook URL
  • packages/api/src/routers/api/__tests__/webhooks.int.test.ts:636 — Found potential Slack Webhook URL
  • …and 22 more (see detailed results)
  • ✅ How to fix: Remove this key and replace it with a reference from the secrets manager.
  • 📖 Full docs & exception process

⚠️ Warnings (non-blocking — worth reviewing)

  • block_clickhouse_client_create_client_usage (8 items) — detailed results (inline comments only on changed lines) · 📖 docs
  • dependency_license_check (1 item) — detailed results (inline comments only on changed lines) · 📖 docs
  • production_sidecar_verification_check (1 item) — detailed results (inline comments only on changed lines) · 📖 docs

🔍 View detailed quality gate results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant