Repository navigation
Improve time-picker context and preset search for staging - #17
Open
akshay-ghl wants to merge 1 commit into
Open
akshay-ghl wants to merge 1 commit into
akshay-ghl wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
⛔ This PR is blocked1 critical check(s) failed. Critical gates enforce security & compliance — the PR cannot merge until they pass. Each failing gate and how to fix it is listed below. Quality Gate Results⛔ 1 Critical failed — blocking ❌ Must fix before merging
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared time picker now shows the input timezone, full timestamps with offsets, and elapsed duration. Search narrows the existing presets without submitting a query; clearing by keyboard retains focus and cannot trigger the global Apply shortcut.
Inspired by Grafana time controls and the inspected official time-series demo. Reuses HyperDX's parser, preferences, Mantine controls and theme tokens. No dependencies, APIs, retention changes or query behavior changes.
Staging dependency: targets
deploy/dashboard-interactions-stg, the source of deployed custom.60 (cee727a8, PR #16). The sourcestgbranch lacks that recovered UI baseline. This is a focused stacked PR for US Central staging, not a request to merge the broader recovery PR or deploy automatically.Validation:
yarn lint:fixfails on the existing restricted import inSQLInlineEditor.commentCommand.test.ts; unrelated formatting was excluded.Limits: preview describes the outer input, not unsaved calendar fields or fetched results. Relative previews resolve on open, not continuously; unparseable input, including Live Tail, shows timezone without inventing timestamps. Local evidence uses actual shared components with synthetic data. Full authenticated consumer-page checks, screen-reader testing, production-image build and live staging validation remain pending. No Helm/image/deployment changes.
Follow-up proposals, not included: recent absolute ranges; copying investigation context; per-panel refresh/error feedback. Existing Min/Max/Last legends are unchanged.