Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Enable HTTPS Everywhere on Vox Media properties - #9700

Closed
iamcarrico wants to merge 8 commits into
EFForg:masterfrom
iamcarrico:voxmedia
Closed

iamcarrico wants to merge 8 commits into
EFForg:masterfrom
iamcarrico:voxmedia

Conversation

@iamcarrico

Copy link
Copy Markdown

Howdy!

I am not entirely sure if all of these are 100% correct— but the following sites all have HTTPS enabled on them, and we should probably have them all enabled by default now. Let me know if there is any other information I can help provide.

Sites enabled:

  • vox.com
  • theverge.com
  • eater.com
  • racked.com
  • curbed.com
  • polygon.com
  • recode.net

I followed the PR pattern from #9326, but am happy to spend some time making improvements as requested.

I have been waiting and wanting to do a PR like this for some time... I hope we can make good things happen

@jeremyn jeremyn mentioned this pull request Apr 29, 2017
@jeremyn jeremyn mentioned this pull request May 1, 2017
Comment thread src/chrome/content/rules/Eater.xml Outdated
<target host="*.eater.com" />


<rule from="^http://eater\.com/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This redirect is not necessary.

Comment thread src/chrome/content/rules/Eater.xml Outdated

<!-- Direct rewrites:
-->
<target host="www.eater.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wildcard target makes this obsolete.

<!-- Complications:
-->
<target host="eater.com" />
<target host="*.eater.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We require at least 3 test urls for wildcards. Please add as many different hosts as you can.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comments on the top. You may update/remove them if all hosts are working now.

<target host="hamptons.curbed.com" />
<target host="ny.curbed.com" />
<target host="www.ny.curbed.com" />
<target host="www.curbed.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard target makes this obsolete, but you should add curbed.com.

<target host="ny.curbed.com" />
<target host="www.ny.curbed.com" />
<target host="www.curbed.com" />
<target host="*.curbed.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the comment section on the top.


* CORS issues, https://github.com/EFForg/https-everywhere/issues/7381
-->
<ruleset name="Racked.com" default_off="CORS issues">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the comments.

<ruleset name="Racked.com" default_off="CORS issues">
<ruleset name="Racked.com">
<target host="racked.com" />
<target host="www.racked.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more subdomains. Could you add them too?


<!-- Complications:
-->
<target host="vox.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also:
conversations.vox.com
votecompass.vox.com

Comment thread src/chrome/content/rules/Vox.com.xml Outdated
<test url="http://vox.com/2016/1/7/10726296/wheres-rey-star-wars-monopoly" />

<rule from="^http://vox\.com/"
to="https://www.vox.com/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ^ to www redirect is not necessary.


-->
<ruleset name="Vox Media.com (partial)">
<ruleset name="Vox Media.com=">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a typo.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the comment section.

@J0WI

J0WI commented May 29, 2017

Copy link
Copy Markdown
Contributor

There are a lot of changes to review, I would prefer to have one PR for each file.

@ghost

ghost commented Jun 3, 2017

Copy link
Copy Markdown

@iamcarrico Did you look into J0WI's review of your PR?

@iamcarrico

Copy link
Copy Markdown
Author

Yeah, sorry— just behind here. I will get them all in there. I just got access to all of our DNS information to ensure that I can add in the appropriate tests.

@J0WI

J0WI commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

@iamcarrico can you share any news about the progress here?

@iamcarrico

Copy link
Copy Markdown
Author

Slow. Just not able to find a lot of spare time right now. I just pushed the work from the past couple weeks— I am also working to ensure the securecookie changes can be pushed into our production site as soon as possible.

@jeremyn

jeremyn commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

@iamcarrico If you don't plan on working on this in the foreseeable future, please close the PR. Also, in any case it's best if PRs focus on just one file each if possible, so if you do want to update these rulesets in the future, you should make one PR for curbed.com, another for eater.com and so on.

@jeremyn

jeremyn commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

@iamcarrico Also, as a general clean-up action, we'll close this PR soon if we don't hear from you.

@jeremyn

jeremyn commented Dec 22, 2017

Copy link
Copy Markdown
Contributor

I'm closing this pull request due to lack of response from @iamcarrico .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants