Repository navigation
Enable HTTPS Everywhere on Vox Media properties - #9700
iamcarrico wants to merge 8 commits into
Conversation
| <target host="*.eater.com" /> | ||
|
|
||
|
|
||
| <rule from="^http://eater\.com/" |
There was a problem hiding this comment.
This redirect is not necessary.
|
|
||
| <!-- Direct rewrites: | ||
| --> | ||
| <target host="www.eater.com" /> |
There was a problem hiding this comment.
the wildcard target makes this obsolete.
| <!-- Complications: | ||
| --> | ||
| <target host="eater.com" /> | ||
| <target host="*.eater.com" /> |
There was a problem hiding this comment.
We require at least 3 test urls for wildcards. Please add as many different hosts as you can.
There was a problem hiding this comment.
Please have a look at the comments on the top. You may update/remove them if all hosts are working now.
| <target host="hamptons.curbed.com" /> | ||
| <target host="ny.curbed.com" /> | ||
| <target host="www.ny.curbed.com" /> | ||
| <target host="www.curbed.com" /> |
There was a problem hiding this comment.
The wildcard target makes this obsolete, but you should add curbed.com.
| <target host="ny.curbed.com" /> | ||
| <target host="www.ny.curbed.com" /> | ||
| <target host="www.curbed.com" /> | ||
| <target host="*.curbed.com" /> |
There was a problem hiding this comment.
Please also update the comment section on the top.
|
|
||
| * CORS issues, https://github.com/EFForg/https-everywhere/issues/7381 | ||
| --> | ||
| <ruleset name="Racked.com" default_off="CORS issues"> |
There was a problem hiding this comment.
Please also update the comments.
| <ruleset name="Racked.com" default_off="CORS issues"> | ||
| <ruleset name="Racked.com"> | ||
| <target host="racked.com" /> | ||
| <target host="www.racked.com" /> |
There was a problem hiding this comment.
There are some more subdomains. Could you add them too?
|
|
||
| <!-- Complications: | ||
| --> | ||
| <target host="vox.com" /> |
There was a problem hiding this comment.
See also:
conversations.vox.com
votecompass.vox.com
| <test url="http://vox.com/2016/1/7/10726296/wheres-rey-star-wars-monopoly" /> | ||
|
|
||
| <rule from="^http://vox\.com/" | ||
| to="https://www.vox.com/" /> |
There was a problem hiding this comment.
The ^ to www redirect is not necessary.
|
|
||
| --> | ||
| <ruleset name="Vox Media.com (partial)"> | ||
| <ruleset name="Vox Media.com="> |
There was a problem hiding this comment.
Please also update the comment section.
|
There are a lot of changes to review, I would prefer to have one PR for each file. |
|
@iamcarrico Did you look into J0WI's review of your PR? |
|
Yeah, sorry— just behind here. I will get them all in there. I just got access to all of our DNS information to ensure that I can add in the appropriate tests. |
|
@iamcarrico can you share any news about the progress here? |
|
Slow. Just not able to find a lot of spare time right now. I just pushed the work from the past couple weeks— I am also working to ensure the |
|
@iamcarrico If you don't plan on working on this in the foreseeable future, please close the PR. Also, in any case it's best if PRs focus on just one file each if possible, so if you do want to update these rulesets in the future, you should make one PR for |
|
@iamcarrico Also, as a general clean-up action, we'll close this PR soon if we don't hear from you. |
|
I'm closing this pull request due to lack of response from @iamcarrico . |
Howdy!
I am not entirely sure if all of these are 100% correct— but the following sites all have HTTPS enabled on them, and we should probably have them all enabled by default now. Let me know if there is any other information I can help provide.
Sites enabled:
I followed the PR pattern from #9326, but am happy to spend some time making improvements as requested.