Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Recode.net.xml - #7344

Closed
jeremyn wants to merge 1 commit into
EFForg:masterfrom
jeremyn:update-recode.net.xml
Closed

jeremyn wants to merge 1 commit into
EFForg:masterfrom
jeremyn:update-recode.net.xml

Conversation

@jeremyn

@jeremyn jeremyn commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

@J0WI

J0WI commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

Could you leave some comments why the exclusion is needed?

@jeremyn

jeremyn commented Oct 14, 2016

Copy link
Copy Markdown
Contributor Author

I don't understand them myself, the exclusion comments are weird. The old comments construct a different exclusion than it had, for example what happened to authors and the nested negative lookaheads? What do Avoid potential XHR problems and Lessen non-Tor distinguishability mean? What is going on with style?

@J0WI

J0WI commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

I would just keep them.

@jeremyn

jeremyn commented Oct 20, 2016

Copy link
Copy Markdown
Contributor Author

I feel somewhat strongly that we should delete outdated or misleading comments when we can.

@J0WI

J0WI commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

Sure, but we still have them in the exclusion pattern, so they are not outdated.

@jeremyn

jeremyn commented Oct 20, 2016

Copy link
Copy Markdown
Contributor Author

The comments don't exactly match the exclusion pattern so they should be updated, but I don't know what the comments are talking about so I'm not comfortable updating them. So, instead I've deleted them.

@jeremyn

jeremyn commented May 1, 2017

Copy link
Copy Markdown
Contributor Author

I'm closing this as a duplicate of either pull request #9583 or #9700 .

@jeremyn jeremyn closed this May 1, 2017
@jeremyn
jeremyn deleted the update-recode.net.xml branch May 1, 2017 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recode.net (partial) breaks images

3 participants