Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Recode.net.xml - #9583

Merged
jeremyn merged 5 commits into
EFForg:masterfrom
J0WI:recode
Dec 1, 2017
Merged

jeremyn merged 5 commits into
EFForg:masterfrom
J0WI:recode

Conversation

@J0WI

@J0WI J0WI commented Apr 18, 2017 •

Copy link
Copy Markdown
Contributor

See also #7344

@jeremyn

jeremyn commented Apr 28, 2017

Copy link
Copy Markdown
Contributor

@J0WI Is this new PR because Recode.net has improved their HTTPS coverage and now we don't need all those exclusions in my older PR?

@J0WI

J0WI commented Apr 29, 2017

Copy link
Copy Markdown
Contributor Author

Exactly. And I also added events.recode.net.

@jeremyn

jeremyn commented Apr 29, 2017

Copy link
Copy Markdown
Contributor

A person from Vox Media (which controls Recode.net) recently created PR #9700 for Vox domains. I think you and I should close our Recode PRs in favor of #9700 . What do you think?

@iamcarrico

Copy link
Copy Markdown

Sorry, I didn't see this PR— I just went through all our properties that are defaulting to HTTPS now.

@J0WI

J0WI commented May 1, 2017

Copy link
Copy Markdown
Contributor Author

@iamcarrico could you increase the coverage of targets in your pending PR?
E.g. here I also added events.recode.net. If a host doesn't support HTTPS we use to list them in comments for future maintenance.

@jeremyn jeremyn mentioned this pull request May 1, 2017
@iamcarrico

Copy link
Copy Markdown

I am doing a full audit of our subdomains and will add that in.

Note: I am moving cross country this week— so implementation will be slightly delayed.

@jeremyn

jeremyn commented Oct 30, 2017

Copy link
Copy Markdown
Contributor

@J0WI What do you want to do with this PR?

@J0WI

J0WI commented Oct 30, 2017

Copy link
Copy Markdown
Contributor Author

Since there is no progress in #9700 I would love to see this merged.

@jeremyn

jeremyn commented Oct 31, 2017 •

Copy link
Copy Markdown
Contributor

Mark as Invalid certificate or similar:

Add target:

Also:

  • Note in the top comment that https://on.recode.net is covered in Bitly_branded_short_domains.xml
  • Remove the securecookie tag or make it more specific (because we have a failing subdomain)

@jeremyn jeremyn self-assigned this Oct 31, 2017
@jeremyn jeremyn closed this Oct 31, 2017
@jeremyn jeremyn reopened this Oct 31, 2017
@iamcarrico

Copy link
Copy Markdown

Sorry y'all— I have not been able to get back to this. The structure is unfamiliar, and every time I tried I kept getting bogged down. I can say for certain that all of our sites are 100% HTTPS as of now though.

@jeremyn

jeremyn commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

@iamcarrico That's fine, thanks for following up. If you are going to step back from making Vox rulesets indefinitely, please put a note in your PR #9700 and close it.

Also, just FYI, for HTTPS Everywhere we consider domains rather than sites, so for example https://photos.recode.net has an invalid certificate and so we won't include it in our rulesets. From the certificate error it looks like you are relabeling a SmugMug site under recode.net, so I can understand if you don't consider it one of your sites, but for us, it is. The best way to signal that all of your sites are covered by HTTPS is to add them to the HSTS preload list. When that happens, the domains should eventually be removed from HTTPS Everywhere.

@iamcarrico

Copy link
Copy Markdown

I'll make a ticket to remove that domain— I think it is just legacy gunk. Thank you.

@jeremyn

jeremyn commented Nov 26, 2017

Copy link
Copy Markdown
Contributor

@J0WI Can we move forward on this? I have a checklist #9583 (comment).

@J0WI

J0WI commented Nov 26, 2017

Copy link
Copy Markdown
Contributor Author

on.recode.net is already handled by Bitly_branded_short_domains.xml

@jeremyn

jeremyn commented Nov 28, 2017

Copy link
Copy Markdown
Contributor

I've updated the checklist through 0a6f921.

There are other cookies at https://www.recode.net besides ^_chorus_geoip_continent$ that are secure: false. You can just use a .+ for the securecookie name.

@J0WI

J0WI commented Dec 1, 2017

Copy link
Copy Markdown
Contributor Author

Done.

@jeremyn
jeremyn merged commit 33d5693 into EFForg:master Dec 1, 2017
@jeremyn

jeremyn commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

Thanks, merged.

@jeremyn jeremyn removed their assignment Dec 1, 2017
@J0WI
J0WI deleted the recode branch December 2, 2017 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants