Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add skiplist to http.checker.config - #6689

Merged
jeremyn merged 1 commit into
EFForg:masterfrom
fuglede:add-skiplist
Aug 31, 2016
Merged

jeremyn merged 1 commit into
EFForg:masterfrom
fuglede:add-skiplist

Conversation

@fuglede

@fuglede fuglede commented Aug 31, 2016 •

Copy link
Copy Markdown
Contributor

The purpose of this commit is to avoid having Travis hit whitelisted rulesets in test/fetch.sh which caused some unexpected behaviour in #6684 (and possibly other places?)

I suppose one should really ask oneself why the skiplist is not already in there, and what the expected behaviour actually should be, but when I put in the config last year, I think I just omitted it by mistake. At least, I can't really come with any reason for doing it on purpose.

For testing, I added the contents of this PR to #6684 after which all tests were green.

@fuglede fuglede mentioned this pull request Aug 31, 2016
@jeremyn
jeremyn merged commit d5ae51a into EFForg:master Aug 31, 2016
@jeremyn

jeremyn commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

Good catch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants