Repository navigation
[Lenovo] Add exclusion - #6684
Conversation
|
What's the purpose of EDIT: which is sort of funny when you realize I recently updated a script that modifies that file in pull request #6246. EDIT2: fixed bad grammar in first edit EDIT3: convenience link to |
|
@jeremyn: When the ruleset test requirements were introduced last year, the requirements would not be satisfied for a large part of the existing ruleset collection. Thus, a whitelist was introduced to allow the test to run. Each entry consists of the name of the whitelisted ruleset together with its Now, the obvious question is why the test ran anyway ... |
|
Oh, I see. I just had a hassle with test failures in pull request #6683, though not as many as you have here. If I had added |
|
By the way, I looked at this and couldn't figure it out. My vague idea is that something is wrong in Travis. |
|
I found the explanation; see #6689. |
|
Why did you remove the trailing slash from <exclusion pattern="^http://www\.lenovo\.com/(?:lenovorecovery|support|training)" />and the related tests? Also, you can remove the |
|
Fixed the non-capturing groups. I removed the slash to ensure that the pattern would match both http://www.lenovo.com/lenovorecovery and http://www.lenovo.com/lenovorecovery/ (and similarly for the others; note that https://www.lenovo.com/training is currently broken). |
|
Thanks for updating the non-capturing groups. I see what you mean about the trailing slash. In #5601 we're discussing some ambiguity about trailing slashes. It'd be great if you could contribute to that discussion. |
This closes https://trac.torproject.org/projects/tor/ticket/18055