Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix BusinessInsider.xml video - #6683

Merged
J0WI merged 3 commits into
EFForg:masterfrom
jeremyn:fix-businessinsider-video
Sep 2, 2016
Merged

J0WI merged 3 commits into
EFForg:masterfrom
jeremyn:fix-businessinsider-video

Conversation

@jeremyn

@jeremyn jeremyn commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

This should fix issue #5014 regarding broken video on businessinsider.com (example here). Commits 9ea45fb and 1e0802e fix these errors I get with fetch-test.sh:

ERROR rules/BusinessInsider.xml: Fetch error: http://www.businessinsider.com/account => https://www.businessinsider.com/account: Too many redirects while fetching 'https://www.businessinsider.com/account'
ERROR rules/BusinessInsider.xml: Fetch error: http://www.businessinsider.com/register => https://www.businessinsider.com/register: Too many redirects while fetching 'https://www.businessinsider.com/register'
ERROR rules/BusinessInsider.xml: Fetch error: http://jobs.businessinsider.com/c/ => https://businessinsider.jobamatic.com/c/: (7, 'Failed to connect to businessinsider.jobamatic.com port 443: Connection refused')
ERROR rules/BusinessInsider.xml: Fetch error: http://insider.businessinsider.com/ => https://insider.businessinsider.com/: (6, 'Could not resolve host: insider.businessinsider.com')
ERROR rules/BusinessInsider.xml: Fetch error: http://oascentral.businessinsider.com/ => https://oascentral.businessinsider.com/: (6, 'Could not resolve host: oascentral.businessinsider.com')

@Hainish Hainish added the top-1k label Aug 30, 2016
@jeremyn jeremyn mentioned this pull request Aug 30, 2016
@J0WI

J0WI commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

Why did you change this?

@jeremyn

jeremyn commented Sep 1, 2016

Copy link
Copy Markdown
Contributor Author

Your "this" link is 404ing for me. What change do you mean?

@jeremyn

jeremyn commented Sep 1, 2016

Copy link
Copy Markdown
Contributor Author

If this mean this, that change is to fix these errors:

ERROR rules/BusinessInsider.xml: Fetch error: http://www.businessinsider.com/account => https://www.businessinsider.com/account: Too many redirects while fetching 'https://www.businessinsider.com/account'
ERROR rules/BusinessInsider.xml: Fetch error: http://www.businessinsider.com/register => https://www.businessinsider.com/register: Too many redirects while fetching 'https://www.businessinsider.com/register'

@J0WI

J0WI commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

This means this:
1e0802e

@jeremyn

jeremyn commented Sep 2, 2016

Copy link
Copy Markdown
Contributor Author

That's what I guessed you were referring to in this comment, so my answer there applies.

@J0WI

J0WI commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

All right, therefore it lgtm.

@J0WI
J0WI merged commit 7e015bd into EFForg:master Sep 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants