Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update whitelist for FierceMarkets.xml - #6869

Merged
J0WI merged 1 commit into
EFForg:masterfrom
jeremyn:update-whitelist-for-fiercemarkets.xml
Sep 14, 2016
Merged

J0WI merged 1 commit into
EFForg:masterfrom
jeremyn:update-whitelist-for-fiercemarkets.xml

Conversation

@jeremyn

@jeremyn jeremyn commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

This updates the whitelist following the change in pull request #6243 .

@fuglede @Hainish @J0WI Please review this soon because this is breaking Travis.

@J0WI

J0WI commented Sep 14, 2016

Copy link
Copy Markdown
Contributor

I wonder why the tests passed in #6243 .

@J0WI
J0WI merged commit 512c612 into EFForg:master Sep 14, 2016
@jeremyn

jeremyn commented Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

I'm not totally sure but there were recent changes to how the whitelist is handled in Travis, see pull request #6689 . If you were relying on a test ran last month then the test result may have been outdated.

@fuglede

fuglede commented Sep 14, 2016 •

Copy link
Copy Markdown
Contributor

Sounds weird; do you have a reference for a broken build? https://travis-ci.org/EFForg/https-everywhere/builds looks mostly green.

@jeremyn

jeremyn commented Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

@fuglede

fuglede commented Sep 14, 2016 •

Copy link
Copy Markdown
Contributor

Thanks for the reference. #6689 only concerned fetch testing, so that should not be relevant here.

In fact, the job from #6243 correctly caught the failure (see https://travis-ci.org/EFForg/https-everywhere/jobs/152052034) but the docker run gave the wrong return value, leading to the false green; I could imagine that this would be fixed now that the test has been split into six different ones -- I guess we'll find out pretty quickly if it goes awry again, but maybe @Hainish will also be able to tell immediately?

@jeremyn
jeremyn deleted the update-whitelist-for-fiercemarkets.xml branch September 14, 2016 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants