Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added ruleset for baf.bund.de - #14960

Merged
Bisaloo merged 2 commits into
EFForg:masterfrom
Jochen-A-Fuerbacher:baf.bund.de
Mar 23, 2018
Merged

Bisaloo merged 2 commits into
EFForg:masterfrom
Jochen-A-Fuerbacher:baf.bund.de

Conversation

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor

No description provided.

@Bisaloo

Bisaloo commented Mar 22, 2018

Copy link
Copy Markdown
Collaborator

Does it make sense to keep a list of related rulesets in Verwaltung_Online.xml?

See this comment from @jeremyn about *.gov targets. In the same idea, the domain gouv.fr for the French government for example should actually be considered as a TLD.

What do you think?

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

Well, I just continued the list at Verwaltung_Online.xml someone else started. In other pull requests I was told to include a reference at Verwaltung_Online.xml so I did it (see this comment by @J0WI ). I am fine to remove the list at Verwaltung_Online.xml but I think, this should be done in another pull request.

@J0WI What to you think about this?

@jeremyn

jeremyn commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

@J0WI and I have disagreed about comments like this in the past. See PR #10468 "separate ag.ch" where we debated whether swissgov.xml, for domains related to the national Swiss government, should have a reference to ag.ch.xml, which is for domains related to a particular local Swiss political entity that is, as far as I know, unrelated to the national government. We didn't reach an agreement on the issue, but instead I let it go to keep the PR moving forward.

In this case I'm okay with @Jochen-A-Fuerbacher updating an existing list, not because I agree with it, but because I don't want to put @Jochen-A-Fuerbacher in the middle of this disagreement.

@Bisaloo

Bisaloo commented Mar 22, 2018

Copy link
Copy Markdown
Collaborator

I agree this belongs to another PR anyways so let's move forward with this one.

Can you also add targets for https://www.anlagenschutz.baf.bund.de and http://test.anlagenschutz.baf.bund.de please?

@Bisaloo Bisaloo self-assigned this Mar 22, 2018
@Bisaloo Bisaloo closed this Mar 22, 2018
@Bisaloo Bisaloo reopened this Mar 22, 2018
@Bisaloo
Bisaloo merged commit 4967647 into EFForg:master Mar 23, 2018
@Jochen-A-Fuerbacher
Jochen-A-Fuerbacher deleted the baf.bund.de branch March 24, 2018 07:09
@Bisaloo Bisaloo removed their assignment Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants