Repository navigation
[US-government] Delete ruleset - #11510
Conversation
|
This entire ruleset is an anti-pattern. US government agencies/IT services can be as independent from one another as two different corporations, especially across federal/state/city lines. If someone needs a list of all US federal websites, they can look at for example https://pulse.cio.gov/https/domains/ . This ruleset should be deleted and existing groups moved into independent rulesets such as (I've also commented on this in PR #10468.) |
|
Linking #11348 P.S. I am fine if this ruleset is going to be removed. It is really bad in the sense that it include too many domains which should be covered in other, independent rulesets. |
|
I'm totally fine with splitting it as well. I agree that we should use different rulesets for different domains. I don't really care about what happens to the top comment. I have never really been convinced of its usefulness anyways. @cschanaj, do you want to do it? |
|
I would like to continue my work on removing the outdated https-everywhere-checker comment, please feel free to do anything you want. I will close #11348. thanks! |
|
I left one target because I think comments about non-functional subdomains can still be useful. So we should probably keep this ruleset until all comments are moved to relevant distinct rulesets. @cschanaj also found many more working targets but they should be added in separate rulesets in later PR otherwise this will become too painful to review. @jeremyn, thoughts? |
|
I know |
|
I disagree with keeping the list of nonfunctional domains for the same reasons I gave in PR #10468 (comment):
|
|
@jeremyn, I agree with you. At some point, the But, for the time being, it contains valuable information, that is not stored anywhere else. If I remove it now, we lose that information (or we need to dig through git history). This is what I meant. So it's probably a good idea to wait until that info has been migrated before deleting it. Do you see what I mean? Do you still think it should be removed now? |
|
Actually, I had a look at the comments and they weren't that useful. So I went ahead and removed |
|
Which comments/PR? |
|
Should I remove the comments from other rulesets linking to |
|
Yes, please delete references to |
|
(Reminder to myself to solve conflicts in #11513 when this PR is merged.) |
|
Is it okay if I whitelist all rulesets failing coverage test? |
|
Let's just not edit those files -- that is, let's leave in the dangling references to The alphabetically sorted list of failing rulesets from Travis is:
|
|
Thank you for the list. For future reference, I also had to remove:
|
|
I don't see https://m.hivtest.cdc.gov failing Travis anywhere. |
It was timing out before I restarted the tests. List of all excluded files:
|
|
There are a small number of problems with the changes, however I merged anyway. It would be nice if you could make new PRs (and ping me) for these problems:
|
The dead links are caused by
hsts-prune.