Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[US-government] Delete ruleset - #11510

Merged
jeremyn merged 17 commits into
EFForg:masterfrom
Bisaloo:patch-24
Aug 9, 2017
Merged

jeremyn merged 17 commits into
EFForg:masterfrom
Bisaloo:patch-24

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Jul 29, 2017 •

Copy link
Copy Markdown
Collaborator

The dead links are caused by hsts-prune.

@Bisaloo Bisaloo changed the title [US-government] Remove dead links [US-government] Update and reactivate ruleset Jul 29, 2017
@jeremyn

jeremyn commented Jul 29, 2017

Copy link
Copy Markdown
Contributor

This entire ruleset is an anti-pattern. US government agencies/IT services can be as independent from one another as two different corporations, especially across federal/state/city lines. If someone needs a list of all US federal websites, they can look at for example https://pulse.cio.gov/https/domains/ .

This ruleset should be deleted and existing groups moved into independent rulesets such as Census.gov.xml.

(I've also commented on this in PR #10468.)

@cschanaj

cschanaj commented Jul 30, 2017 •

Copy link
Copy Markdown
Collaborator

Linking #11348

P.S. I am fine if this ruleset is going to be removed. It is really bad in the sense that it include too many domains which should be covered in other, independent rulesets.

@Bisaloo

Bisaloo commented Jul 30, 2017

Copy link
Copy Markdown
Collaborator Author

I'm totally fine with splitting it as well. I agree that we should use different rulesets for different domains.

I don't really care about what happens to the top comment. I have never really been convinced of its usefulness anyways.

@cschanaj, do you want to do it?

@cschanaj

Copy link
Copy Markdown
Collaborator

I would like to continue my work on removing the outdated https-everywhere-checker comment, please feel free to do anything you want. I will close #11348. thanks!

@Bisaloo

Bisaloo commented Aug 1, 2017 •

Copy link
Copy Markdown
Collaborator Author

I left one target because I think comments about non-functional subdomains can still be useful. So we should probably keep this ruleset until all comments are moved to relevant distinct rulesets.

@cschanaj also found many more working targets but they should be added in separate rulesets in later PR otherwise this will become too painful to review.

@jeremyn, thoughts?

@Bisaloo

Bisaloo commented Aug 1, 2017

Copy link
Copy Markdown
Collaborator Author

I know NASA.gov.xml is still default_off but this work should be done in another PR IMO.

@jeremyn

jeremyn commented Aug 1, 2017

Copy link
Copy Markdown
Contributor

I disagree with keeping the list of nonfunctional domains for the same reasons I gave in PR #10468 (comment):

I'm saying the canton rulesets/domains aren't related to the federal ruleset, so they shouldn't be linked to the federal ruleset, and that list shouldn't be there. Where that list should be is unrelated. There are thousands/millions of other unrelated domains that also don't support HTTPS, and I wouldn't put them in swissgov.xml either.

@Bisaloo

Bisaloo commented Aug 2, 2017

Copy link
Copy Markdown
Collaborator Author

@jeremyn, I agree with you. At some point, the US-government.xml should be entirely removed.

But, for the time being, it contains valuable information, that is not stored anywhere else. If I remove it now, we lose that information (or we need to dig through git history).

This is what I meant. So it's probably a good idea to wait until that info has been migrated before deleting it.

Do you see what I mean? Do you still think it should be removed now?

@Bisaloo

Bisaloo commented Aug 2, 2017

Copy link
Copy Markdown
Collaborator Author

Actually, I had a look at the comments and they weren't that useful. So I went ahead and removed US-government.xml. Should I also remove the comments pointing to it in that PR?

@jeremyn

jeremyn commented Aug 2, 2017

Copy link
Copy Markdown
Contributor

Which comments/PR?

@Bisaloo

Bisaloo commented Aug 2, 2017

Copy link
Copy Markdown
Collaborator Author

Should I remove the comments from other rulesets linking to US-government.xml (for example) here, in this PR? Or should I do it in a new PR?

@jeremyn

jeremyn commented Aug 3, 2017

Copy link
Copy Markdown
Contributor

Yes, please delete references to US-government.xml from other files in this PR.

@jeremyn jeremyn self-assigned this Aug 3, 2017
@Bisaloo

Bisaloo commented Aug 4, 2017 •

Copy link
Copy Markdown
Collaborator Author

(Reminder to myself to solve conflicts in #11513 when this PR is merged.)

@Bisaloo

Bisaloo commented Aug 4, 2017

Copy link
Copy Markdown
Collaborator Author

Is it okay if I whitelist all rulesets failing coverage test?

@jeremyn

jeremyn commented Aug 5, 2017

Copy link
Copy Markdown
Contributor

Let's just not edit those files -- that is, let's leave in the dangling references to US-government.xml. The references can be removed the next time someone looks at those files.

The alphabetically sorted list of failing rulesets from Travis is:

  • Argonne-National-Laboratory.xml
  • Bonneville_Power_Administration.xml
  • City-of-Chicago.xml
  • City-of-Sedona.xml
  • City_of_Seattle.xml
  • Federal-Communications-Commission.xml
  • NCRIC.xml
  • National-Renewable-Energy-Laboratory.xml
  • Pay.gov.xml
  • State_of_Alaska.xml
  • US_Citizenship_and_Immigration_Services.xml
  • US_Patent_and_Trademark_Office.xml
  • United-States-Department-of-Energy.xml

@Bisaloo

Bisaloo commented Aug 5, 2017

Copy link
Copy Markdown
Collaborator Author

Thank you for the list. For future reference, I also had to remove:

  • DHS.gov.xml
  • State_of_Oregon.xml

@Bisaloo

Bisaloo commented Aug 5, 2017

Copy link
Copy Markdown
Collaborator Author

https://m.hivtest.cdc.gov/ WFM

@Bisaloo Bisaloo closed this Aug 5, 2017
@Bisaloo Bisaloo reopened this Aug 5, 2017
@jeremyn

jeremyn commented Aug 6, 2017

Copy link
Copy Markdown
Contributor

I don't see https://m.hivtest.cdc.gov failing Travis anywhere.

@Bisaloo Bisaloo closed this Aug 8, 2017
@Bisaloo Bisaloo reopened this Aug 8, 2017
@Bisaloo

Bisaloo commented Aug 9, 2017

Copy link
Copy Markdown
Collaborator Author

I don't see m.hivtest.cdc.gov failing Travis anywhere.

It was timing out before I restarted the tests.

List of all excluded files:

  • Argonne-National-Laboratory.xml
  • Bonneville_Power_Administration.xml
  • City-of-Chicago.xml
  • City-of-Sedona.xml
  • City_of_Seattle.xml
  • Consumer_Finance.gov.xml
  • DHS.gov.xml
  • Federal-Communications-Commission.xml
  • Federal_Reserve.org.xml
  • NCRIC.xml
  • National-Renewable-Energy-Laboratory.xml
  • Pay.gov.xml
  • State_of_Alaska.xml
  • State_of_Oregon.xml
  • US_Citizenship_and_Immigration_Services.xml
  • US_Patent_and_Trademark_Office.xml
  • United-States-Department-of-Energy.xml
  • bbg.gov.xml

@jeremyn jeremyn changed the title [US-government] Update and reactivate ruleset [US-government] Delete ruleset Aug 9, 2017
@jeremyn
jeremyn merged commit 0c315c7 into EFForg:master Aug 9, 2017
@jeremyn

jeremyn commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

There are a small number of problems with the changes, however I merged anyway. It would be nice if you could make new PRs (and ping me) for these problems:

  • Add (partial) to the name in House.gov.xml
  • Fill out Export.gov.xml with more domains, because we removed a wildcard entry for it from US-government.xml.

@jeremyn jeremyn removed their assignment Aug 9, 2017
@Bisaloo
Bisaloo deleted the patch-24 branch August 9, 2017 14:32
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants