Repository navigation
[House.gov] Add targets - #11783
[House.gov] Add targets#11783Bisaloo wants to merge 2 commits into
Conversation
|
I don't know if you've seen this or if it would be of any use to you but I made a pull request a while back for this domain: #9706 |
|
No, I did not see that. Thank you! Do you want to continue your work on this ruleset? Or should I integrate your changes to this PR? |
|
You can just integrate whatever changes you feel are necessary into this PR |
|
I'm firmly against a wildcard for I would prefer if this PR just made the very minor change of adding |
|
Ok, @afarrow, the subdomains I added as test url should be safe to add as targets. The full list of representatives can be found in the source code of https://www.house.gov/ starting line 400. For an unclear reason, 4 of them are not linked to the |
|
Ok I created a new PR combining our efforts: #11808 Good find on the list of the subdomains in the source. Saved me a lot of effort. I included some notes (including that one) at the top of the file for future maintainers. Those 4 subdomains that had their http version linked looked fine over https to me so I included them. @jeremyn I went ahead and added |
|
@afarrow A primary reason to avoid wildcards and instead list individual targets is because listing a target implies that someone has looked at the domain and decided it works with HTTPS. Creating a list of 400+ targets using an automated process defeats that purpose. For example, https://capuano.house.gov has some mixed content blocking issues that may just be stylistic but we should look into it. Some other domains that I checked, don't have mixed content blocking. I'm also uninterested in reviewing a ruleset where I have to check 400+ domains before I can approve it. Maybe one of other reviewers will do that but it seems unlikely to me. I have no solution to this problem, I'm just letting you know that I think your PR #11808 is going to have a tough time getting reviewed. |
|
@jeremyn Ok, well then what about taking the approach I took in my first PR which is cover the more general subdomains and ignore the ones for the representatives. If I take out the representatives' subdomains, that yields 65 subdomains to check. That's still a lot but a lot more manageable. We could even do them 10 or 5 at a time if you would prefer. I totally understand what you're saying about not wanting to review >400 subdomains. There's got to be a happy medium we can come to between adding all the subdomains and ignoring this domain. Edit: |
@jeremyn
#11510
I don't like wildcards any more than you do but I don't think we have a choice here.