Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added rule for bbk.bund.de. - #7475

Merged
J0WI merged 5 commits into
EFForg:masterfrom
Jochen-A-Fuerbacher:bbk-bund-de
Feb 28, 2017
Merged

J0WI merged 5 commits into
EFForg:masterfrom
Jochen-A-Fuerbacher:bbk-bund-de

Conversation

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor

No description provided.

@J0WI

J0WI commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

We already have some rules containing bund.de. Maybe you can document the relationship between them or merge the files?

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

Merging those files wouldn't be a good idea, in my opinion. Most of them handle some websites of federal offices of Germany, which doesn't have anything in common.

I could put a comment to the top of this (bbk.bund.de) file, explaining that there are other files for the bund.de domain. Would that be ok?

@J0WI

J0WI commented Feb 13, 2017

Copy link
Copy Markdown
Contributor

Yes, this would be helpful. We already have such references in big rulesets like Amazon.xml or Google.xml.

<target host="austausch.bbk.bund.de" />
<target host="warnung.bund.de" />

<rule from="^http://bbk\.bund\.de/" to="https://www.bbk.bund.de/"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the mismatch.

- Bundesnachrichtendienst.xml
- Bundesministerium_des_Innern.xml
- Federal_Office_of_Administration.xml
- Verwaltung_Online.xml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use to make a reference from the referenced files back to this one. See examples in Google.xml or Amazon.xml.

@J0WI

J0WI commented Feb 17, 2017

Copy link
Copy Markdown
Contributor

In such cases we use to define one 'main ruleset' where all references are listed and then just refer to the list in that main rule. Otherwise we have to maintain the list of references in all related rulesets. See examples in Google.xml or Amazon.xml (and the referred rules there).
I don't know if there is one ruleset of federal offices that could be defined as 'main rule'?

Some of the related rules do not fit our current requirements and break our tests. Could you just fix the errors there? Maybe they need to be rewritten, but this is likely a separate PR.

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

The Verwaltung_Online.xml ruleset contains the main bund.de domain. So I put the list there.

I will look at the rules that break the tests and open an other PR for that.

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

Fixed rules to pass tests in PR #8625.

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

Is there anything still to do here?

@J0WI

J0WI commented Feb 26, 2017

Copy link
Copy Markdown
Contributor

I would like to have all errors fixed before merging. #8626 needs to be reviewed by somebody else. There are still some errors in the fetch test, but they can be fixed here, when this branch gets rebased.

@J0WI

J0WI commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

@Jochen-A-Fuerbacher all dependencies are merged. Could you please rebase your changes and make sure, that all tests are passing?

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

There are now two subdomains in Federal_Office_of_Administration.xml that break tests. See #8853.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants