Repository navigation
Added rule for bbk.bund.de. - #7475
Conversation
|
We already have some rules containing |
|
Merging those files wouldn't be a good idea, in my opinion. Most of them handle some websites of federal offices of Germany, which doesn't have anything in common. I could put a comment to the top of this (bbk.bund.de) file, explaining that there are other files for the bund.de domain. Would that be ok? |
|
Yes, this would be helpful. We already have such references in big rulesets like Amazon.xml or Google.xml. |
| <target host="austausch.bbk.bund.de" /> | ||
| <target host="warnung.bund.de" /> | ||
|
|
||
| <rule from="^http://bbk\.bund\.de/" to="https://www.bbk.bund.de/"/> |
There was a problem hiding this comment.
Please document the mismatch.
| - Bundesnachrichtendienst.xml | ||
| - Bundesministerium_des_Innern.xml | ||
| - Federal_Office_of_Administration.xml | ||
| - Verwaltung_Online.xml |
There was a problem hiding this comment.
We use to make a reference from the referenced files back to this one. See examples in Google.xml or Amazon.xml.
|
In such cases we use to define one 'main ruleset' where all references are listed and then just refer to the list in that main rule. Otherwise we have to maintain the list of references in all related rulesets. See examples in Some of the related rules do not fit our current requirements and break our tests. Could you just fix the errors there? Maybe they need to be rewritten, but this is likely a separate PR. |
|
The I will look at the rules that break the tests and open an other PR for that. |
|
Fixed rules to pass tests in PR #8625. |
|
Is there anything still to do here? |
|
I would like to have all errors fixed before merging. #8626 needs to be reviewed by somebody else. There are still some errors in the fetch test, but they can be fixed here, when this branch gets rebased. |
|
@Jochen-A-Fuerbacher all dependencies are merged. Could you please rebase your changes and make sure, that all tests are passing? |
|
There are now two subdomains in |
7225f31 to
1ec7d53
Compare
1ec7d53 to
e5edd9c
Compare
No description provided.