Repository navigation
Conversation
ghost
commented
Jun 27, 2017
|
ping @Hainish |
Hainish
left a comment
There was a problem hiding this comment.
It would also be good to add an option to the menu for "Show the count of upgraded sites"
| chrome.browserAction.setBadgeBackgroundColor({color: "#00cc00"}); | ||
|
|
||
| const showBadge = activeCount > 0 && isExtensionEnabled; | ||
|
|
There was a problem hiding this comment.
Remove whitespace from this line.
| this.active_tab_rules[tabId][ruleset.name] = ruleset; | ||
| } | ||
|
|
||
| updateState(); |
There was a problem hiding this comment.
I think it makes more sense to place this on what is currently line 325 of this file, so as to eliminate unnecessary calls.
|
@Hainish Done. |
|
@Hainish Will do so in a separate PR. |
|
There appears to be a change in the |
|
@Hainish Maybe I accidentally updated it. |
|
@koops76 do you plan on updating this PR or should I close it? |
|
@Hainish I already fixed all issues with my PR. Do you want me to add the menu option too? |
|
@koops76 this needs to be fixed:
And yes, if you could add the menu option. |
|
@Hainish Done. |
|
Great, last thing is the menu option. |
|
@Hainish Do you mean adding a new checkbox in popup.html? |
|
@Hainish Please merge this unless there is a serious issue preventing this from being merged. Especially since soon Firefox will use the WebExtensions version and the legacy version used to have the counter. |
|
@koops76 #11800 migrates the XPCOM option to show a counter into WebExtensions' storage as |
|
@Hainish Should I add it into |
|
@Hainish Take a look. |
|
I will continue my work on exporting/importing settings in this PR since it depends on the code I have put into it. |
|
@koops76 thanks, let me know when this is in a good place to review. When you think it is, it's helpful for me if you stop making any more commits in this branch so I have a solid, unchanging diff to do code review from. |
|
@koops76 is this ready for review? See above comment |
|
As it stands this PR introduces a lot of non-orthogonal code, completely unrelated to the stated objective. This belongs in another PR, which can be reviewed and merged separately without a pressing deadline. This release is going out today or tomorrow, and it seems this PR is not ready and I will not have the opportunity to give it a proper review before tomorrow's launch. As it stands this functionality will have to wait until next release. |
|
@Hainish OK, I am going to close this and continue working on this branch. Then I will separate changes into their own PRs. |
|
@koops76 any progress on this? It would be great to get into the next version of HTTPS Everywhere. If you submit a PR which adds the badge and reads the storage var for whether it's disabled or not, I can take care of the options page. |
