Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add icon badge in Chromium - #10773

Closed
ghost wants to merge 38 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 38 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jun 27, 2017

Copy link
Copy Markdown

Example of icon badge

@J0WI

J0WI commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

ping @Hainish

@Hainish Hainish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be good to add an option to the menu for "Show the count of upgraded sites"

Comment thread chromium/background.js Outdated
chrome.browserAction.setBadgeBackgroundColor({color: "#00cc00"});

const showBadge = activeCount > 0 && isExtensionEnabled;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove whitespace from this line.

Comment thread chromium/background.js Outdated
this.active_tab_rules[tabId][ruleset.name] = ruleset;
}

updateState();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to place this on what is currently line 325 of this file, so as to eliminate unnecessary calls.

@ghost

ghost commented Jul 6, 2017

Copy link
Copy Markdown
Author

@Hainish Done.

@ghost

ghost commented Jul 6, 2017

Copy link
Copy Markdown
Author

@Hainish Will do so in a separate PR.

@Hainish

Hainish commented Jul 6, 2017

Copy link
Copy Markdown
Member

There appears to be a change in the translations submodule?

@ghost

ghost commented Jul 6, 2017

Copy link
Copy Markdown
Author

@Hainish Maybe I accidentally updated it.

@Hainish

Hainish commented Jul 13, 2017

Copy link
Copy Markdown
Member

@koops76 do you plan on updating this PR or should I close it?

@ghost

ghost commented Jul 14, 2017

Copy link
Copy Markdown
Author

@Hainish I already fixed all issues with my PR. Do you want me to add the menu option too?

@Hainish

Hainish commented Jul 14, 2017

Copy link
Copy Markdown
Member

@koops76 this needs to be fixed:

Submodule translations updated from 020039 to 303723

And yes, if you could add the menu option.

@ghost

ghost commented Jul 14, 2017

Copy link
Copy Markdown
Author

@Hainish Done.

@Hainish

Hainish commented Jul 14, 2017

Copy link
Copy Markdown
Member

Great, last thing is the menu option.

@ghost

ghost commented Aug 7, 2017

Copy link
Copy Markdown
Author

@Hainish Do you mean adding a new checkbox in popup.html?

@ghost ghost mentioned this pull request Aug 7, 2017
@ghost

ghost commented Aug 10, 2017

Copy link
Copy Markdown
Author

@Hainish Please merge this unless there is a serious issue preventing this from being merged. Especially since soon Firefox will use the WebExtensions version and the legacy version used to have the counter.

@Hainish

Hainish commented Aug 10, 2017

Copy link
Copy Markdown
Member

@koops76 #11800 migrates the XPCOM option to show a counter into WebExtensions' storage as showCounter. We've also added an option UI. Having a toggle for the counter is a requirement for deployment, as I can see users having a strong preference either way. The best place for this is in the options dialog.

@ghost

ghost commented Aug 10, 2017

Copy link
Copy Markdown
Author

@Hainish Should I add it into popup.html?

koops76 added 2 commits August 14, 2017 11:28
@ghost

ghost commented Aug 14, 2017

Copy link
Copy Markdown
Author

@Hainish Take a look.

@ghost

ghost commented Aug 14, 2017

Copy link
Copy Markdown
Author

I will continue my work on exporting/importing settings in this PR since it depends on the code I have put into it.

@Hainish

Hainish commented Aug 14, 2017

Copy link
Copy Markdown
Member

@koops76 thanks, let me know when this is in a good place to review. When you think it is, it's helpful for me if you stop making any more commits in this branch so I have a solid, unchanging diff to do code review from.

@Hainish

Hainish commented Aug 14, 2017

Copy link
Copy Markdown
Member

@koops76 is this ready for review? See above comment

@Hainish

Hainish commented Aug 14, 2017

Copy link
Copy Markdown
Member

As it stands this PR introduces a lot of non-orthogonal code, completely unrelated to the stated objective. This belongs in another PR, which can be reviewed and merged separately without a pressing deadline.

This release is going out today or tomorrow, and it seems this PR is not ready and I will not have the opportunity to give it a proper review before tomorrow's launch. As it stands this functionality will have to wait until next release.

@ghost

ghost commented Aug 15, 2017

Copy link
Copy Markdown
Author

@Hainish OK, I am going to close this and continue working on this branch. Then I will separate changes into their own PRs.

@ghost ghost closed this Aug 15, 2017
@Hainish

Hainish commented Aug 23, 2017

Copy link
Copy Markdown
Member

@koops76 any progress on this? It would be great to get into the next version of HTTPS Everywhere. If you submit a PR which adds the badge and reads the storage var for whether it's disabled or not, I can take care of the options page.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants