Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

JS refactoring - #11637

Closed
ghost wants to merge 33 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 33 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 2, 2017 •

Copy link
Copy Markdown

No description provided.

@J0WI
J0WI requested a review from Hainish August 5, 2017 01:10
@ghost ghost changed the title Minor JS tweaks JS refactoring Aug 7, 2017
@ghost ghost mentioned this pull request Aug 7, 2017
@Hainish

Hainish commented Aug 7, 2017

Copy link
Copy Markdown
Member

I won't be able to review this until we have the Embedded WebExtensions code working. See #11639 (comment)

@ghost

ghost commented Aug 7, 2017

Copy link
Copy Markdown
Author

@Hainish Should I rebase this code on WebExtensions branch?

@Hainish

Hainish commented Aug 7, 2017

Copy link
Copy Markdown
Member

@koops76 yes I think that would be good

@ghost

ghost commented Aug 7, 2017

Copy link
Copy Markdown
Author

@Hainish Same with StandardJS/Airbnb/Google style PRs?

@Hainish

Hainish commented Aug 7, 2017

Copy link
Copy Markdown
Member

yes would be good

@ghost

ghost commented Aug 7, 2017 •

Copy link
Copy Markdown
Author

What about Hainish#2?

@ghost

ghost commented Aug 7, 2017 •

Copy link
Copy Markdown
Author

@Hainish Also, can you merge #10773 as it is? I will add the checkbox after this will be merged, popup.js and popup.html code is terrible. I don't want to modify it before refactoring.

@ghost ghost mentioned this pull request Aug 9, 2017
@ghost ghost mentioned this pull request Aug 11, 2017
@ghost ghost closed this Aug 28, 2017
@ghost ghost reopened this Oct 3, 2017
@ghost ghost closed this Oct 3, 2017
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant