Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Badges do not look consistent between HTTPS Everywhere and Privacy Badger #2470

Closed

Description

@qirtaiba

screen shot 2015-08-06 at 4 31 04 pm

Activity

  1. reedy commented on Aug 11, 2015

    @reedy
    Contributor

    Do you mean as to where the numbers are listed, plus size, shape, colour etc?

  2. qirtaiba commented on Aug 11, 2015

    @qirtaiba
    Author

    Yes they just look weird together, it's a visual thing.

    Jeremy Malcolm PhD LLB (Hons) B Com
    Internet lawyer, ICT policy advocate, geek
    echo "9EEAi^^;6C6]>J^=^>6"|tr '!-' 'P-!-O'|wget -q -i - -O -

    On Aug 11, 2015, at 7:43 AM, Sam Reed notifications@github.com wrote:

    Do you mean as to where the numbers are listed, plus size, shape, colour etc?

    —
    Reply to this email directly or view it on GitHub.

  3. reedy commented on Aug 11, 2015

    @reedy
    Contributor

    I don't disagree :). Just wanted to confirm

  4. reedy commented on Aug 11, 2015

    @reedy
    Contributor

    What browser (and version) is this on? And what versions of the 2 extensions? On Chrome 46 on OSX, Privacy Badger 2015.8.5.1 shows the number in the bottom right... And HTTPSE 2015.7.17 doesn't show any numbers.

  5. qirtaiba commented on Aug 11, 2015

    @qirtaiba
    Author

    On 11/08/2015 9:45 am, Sam Reed wrote:

    What browser (and version) is this on? And what versions of the 2
    extensions? On Chrome 46 on OSX, Privacy Badger 2015.8.5.1 shows the
    number in the bottom right... And HTTPSE 2015.7.17 doesn't show any
    numbers.

    Firefox 39, Privacy Badger 1, HTTPS Everywhere 5.0.7.

    Jeremy Malcolm PhD LLB (Hons) B Com
    Internet lawyer, ICT policy advocate, geek
    echo "9EEAi^^;6C6]>J^=^>6"|tr '!-' 'P-!-O'|wget -q -i - -O -

  6. reedy commented on Aug 11, 2015

    @reedy
    Contributor

    screen shot 2015-08-11 at 19 08 34

    This is mine in Chrome...

  7. jsha commented on Aug 11, 2015

    @jsha
    Member

    Yep, the different styles are definitely an issue. Chrome doesn't support the ruleset counter, which I think is fine. On Firefox I'm thinking of making no-counter the default, since it doesn't add much useful information. Instead we could move to a simpler enabled / disabled indicator based on icon size (while still offering the counter for folks who find it useful, like ruleset authors).

  8. fuglede commented on Aug 15, 2015

    @fuglede
    Contributor

    As a side note: Privacy Badger uses the Australis UI/add-on SDK to draw the badge (which is a one-liner including styles and everything), whereas in HTTPS-E it's built with XUL bindings. In particular, this also means that the Privacy Badger badge is not actually drawn on older versions of Firefox (including for instance what's shipped with Debian Jessie). One should be able to restyle rscounter/rsapplied directly to make it consistent with Australis based add-ons (although porting it to Australis entirely might be beneficial in the long run).

  9. fuglede commented on Aug 15, 2015

    @fuglede
    Contributor

    So, I went ahead and stole the styles from the SDK. In my tests, this worked both in Firefox 31 and Firefox 40. The badges have always looked different (and bad) in Linux though, so it would be great if someone could test how they look elsewhere. In particular because it took a bit of manual fiddling to make it look like the Australis style badges (and it is still off by a pixel or three). The style is in the branch fuglede/toolbar-style. Here's how it looks here:

    toolbarstyle

    I think the dropdown arrow should be removed as well (but couldn't quite figure out how to do so¹). Another todo which persists with these changes is to fix #2253.

    References:

    ¹: Doing

    #https-everywhere-button dropmarker {
      display: none !important;
    }
    

    removes the dropmarker, but it also moves the entire toolbar button to the "more tools" menu iff the toolbar button is the rightmost on the navbar.

  10. fuglede commented on Aug 15, 2015

    @fuglede
    Contributor

    One final comment from here: while display: none caused the weird bug where the toolbarbutton would be absorbed into the "more tools" menu, visibility: hidden works completely fine. Here's the result:

    tilgithub3

    It still remains to have it behave nicely when the label is more than a single digit. In the branch above, the label will extend to the right, eventually devouring the other plugins if there are too many active rules. It can be changed to extend to the left by giving #rscounter position: relative; and #rsapplied position: absolute; but then it just pushes the other toolbar buttons to the left instead, which is probably even less desirable. There might be a straightforward CSS fix that I'm missing; otherwise I would guess that the XUL stack in toolbar_button_binding.xml would have to be modified a bit. Here are some screenshots of those two cases:

    tilgithub4

    tilgithub5

  11. reedy commented on Aug 22, 2015

    @reedy
    Contributor

    screen shot 2015-08-22 at 10 47 08

  12. reedy commented on Aug 22, 2015

    @reedy
    Contributor

    screen shot 2015-08-22 at 10 49 00

  13. reedy commented on Aug 22, 2015

    @reedy
    Contributor

    screen shot 2015-08-22 at 10 53 01

  14. fuglede commented on Aug 22, 2015

    @fuglede
    Contributor

    Thanks a lot for testing, @reedy. That's as inconsistent as I feared it would be ... I'm not going to pursue that particular attempt any further; re-doing the XUL seems like the way to go.

  15. jsha commented on Aug 22, 2015

    @jsha
    Member

    Also as an FYI, Mozilla's plan to deprecate XPCOM may mean that in the long run (18 months), XUL is no longer a thing, and we have to migrate to the WebExtensions style of doing things: https://blog.mozilla.org/addons/2015/08/21/the-future-of-developing-firefox-add-ons/. I'm guessing that button stying will be different in that world too.

  16. DerekTurtleRoe commented on Feb 24, 2016

    @DerekTurtleRoe

    @fuglede Those look really good, dude!

    Will they be the same in the WebExtensions port, or will they have to be done again?

  17. fuglede commented on Mar 13, 2016

    @fuglede
    Contributor

    @vgturtle127: I wish they did; that was a naive attempt to copy the Australis toolbarbutton CSS to hopefully get something consistent looking, but it did not work cross-platform. But to answer your question, yes, I'd imagine that in that world, one would use the API to make it look like this.

  18. DerekTurtleRoe commented on Mar 14, 2016

    @DerekTurtleRoe

    @fuglede The WebExtensions port will use that API, right?

  19. fuglede commented on Mar 14, 2016

    @fuglede
    Contributor

    @vgturtle127: I'd imagine so; if I were the one to write it, it would, anyway.

  20. DerekTurtleRoe commented on Mar 15, 2016

    @DerekTurtleRoe

    @fuglede OK, just wanted to make sure.

  21. rugk commented on Aug 15, 2016

    @rugk
    Contributor

    BTW with the new HTTPSE icon this looks worse:
    worsecounter

    HTTPSE 5.2.1, PBadger: 1.8.1, Firefox 48.0, Linux (Cinnamon)

  22. DerekTurtleRoe commented on Aug 24, 2016

    @DerekTurtleRoe

    @rugk Oh, my. 😆

  23. J0WI commented on Oct 20, 2016

    @J0WI
    Contributor

    We should definitively be consistent about the counter position (top-right in ltr)

  24. uniquePWD commented on May 23, 2017

    @uniquePWD

    BTW, I don't have the badge at all on the Firefox WebExtension (test)

  25. J0WI commented on May 29, 2017

    @J0WI
    Contributor

    That's #10002

  26. J0WI commented on Oct 30, 2017

    @J0WI
    Contributor

    fixed in #12552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions