Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

CSS scaling issue for Firefox toolbarbutton in hamburger menu #2253

Closed

Description

@fuglede

This is probably of very low priority, but here goes: When the counter label is shown while the button is in the hamburger/Australis menu, the button (+ label) can become too big to fit in the default grid, which makes it act a bit wonkily, as it forces other buttons to move around.

To reproduce, place the button in the horizontal center of the menu grid, surrounded by other buttons on both sides, and run

document.getElementById("rsapplied").value = "10"

in the browser console.

One obvious fix to this would be to simply not show the label when the button is hidden away; a better one might be to move label a bit (for instance, Ghostery has its label fixed in the lower right corner of its toolbarbutton, which I personally like). It looks like /src/chrome/content/toolbar_button_binding.xml would be the place to change the style.

Activity

  1. jeremyn commented on Sep 3, 2016

    @jeremyn
    Contributor

    @fuglede I can't tell if this is still a problem. Is it?

  2. fuglede commented on Sep 4, 2016

    @fuglede
    ContributorAuthor

    It is. Note that one now has to set devtools.chrome.enabled to true to run commands in the browser console interpreter.

    Here's what it looks like on Firefox 48.0.2 on Windows; it is impossible to have 3 buttons in the row containing the HTTPS Everywhere button:

    untitled

  3. jeremyn commented on Sep 4, 2016

    @jeremyn
    Contributor

    Okay, I see it now. The picture and the devtools.chrome.enabled reference helped.

    Is this really a problem though? You're saying that if you increase the size of the add-on, it pushes other buttons around. What else would happen?

  4. fuglede commented on Sep 6, 2016

    @fuglede
    ContributorAuthor

    No other side effects, I would imagine. As mentioned in the original post, I do consider this low priority. Nonetheless, it did show up in another issue thread as well.

  5. jeremyn commented on Sep 6, 2016

    @jeremyn
    Contributor

    What is the side effect happening here?

  6. fuglede commented on Sep 6, 2016

    @fuglede
    ContributorAuthor

    One unintended effect is that if you have three buttons in the relevant row, then the third button will be forced down when the label grows in size, which in turn can mess up the ordering in the rest of the menu.

  7. jeremyn commented on Sep 6, 2016

    @jeremyn
    Contributor

    If one button becomes too big, what else could Firefox do besides push the other buttons down?

    Or is the issue that you can affect the size of the counter using CSS at all?

  8. fuglede commented on Sep 6, 2016

    @fuglede
    ContributorAuthor

    Well, I simply don't think that we should give rise to the misalignment in the first place. If, for instance, the label extended in the opposite direction, this would not be an issue.

  9. jeremyn commented on Sep 6, 2016

    @jeremyn
    Contributor

    In your picture you mean if the "10" was on the right side over the arrow?

  10. fuglede commented on Sep 6, 2016

    @fuglede
    ContributorAuthor

    I was actually thinking that it could be in the same spot, but that it would extend to the right instead of to the left.

  11. jeremyn commented on Sep 6, 2016

    @jeremyn
    Contributor

    So it would potentially overlap the top left corner of the icon if the number is really big?

  12. fuglede commented on Sep 6, 2016

    @fuglede
    ContributorAuthor

    Yes.

    Really, what will likely happen here is that one day a WebExtensions port will come by, and in that world, there will either be no counter, or the counter logic is built into the button object in such a way that this issue is no longer relevant.

  13. jeremyn commented on Sep 6, 2016

    @jeremyn
    Contributor

    If we weren't redoing it all with WebExtensions, then I would make the fix for this having the counter extend to the right as you said. But since we will eventually redo it, I agree that we should just wait and see. I personally disable the counter during normal use anyway.

  14. pipboy96 commented on Mar 30, 2019

    @pipboy96
    Contributor

    Specific to deprecated version of HTTPSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions