Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Custom user rules not being applied after upgrade to 2017.8.19 #12090

Closed

Description

Firefox ESR 52.3.0 / 64-bit, Debian

I have two rule files in HTTPSEverywhereUserRules under my Firefox profile directory. Both name the hosts specifically; these are not wildcard rules. The files are named as X.ruleset where X is the base domain name (such as, not actually, eff.org rules being in eff.org.ruleset). Both rule files are essentially equivalent to the top example at https://www.eff.org/https-everywhere/rulesets:

<ruleset name="RabbitMQ">
        <target host="rabbitmq.com" />
        <target host="www.rabbitmq.com" />

        <rule from="^http:"
                to="https:" />
</ruleset>

Before the upgrade to 2017.8.19, these rule files worked perfectly.

After the recent upgrade to 2017.8.19, these rule files appear to no longer be read or used. This appears to be the case regardless of whether Javascript is on or off, so I don't think it's related to #12009 or #11948.

Do I need to do something in particular to make these rule files work with the upgraded version?

It is beneficial to be able to actually test rule files locally before submitting them for inclusion (to make sure nothing obvious breaks), and there exists the possibility of wanting to use HTTPS Everywhere with internal hosts (in which case including the rules within the official version would at best cause bloat, and at worst could be at least information leakage).

If the recent upgrade changed how rule files should be written, please make sure to clearly update the documentation accordingly.

Activity

  1. jeremyn commented on Aug 25, 2017

    @jeremyn
    Contributor

    You linked to other issues so I assume you understand that HTTPS Everywhere is slowly migrating to the new WebExtensions way of making extensions.

    The custom rules situation with WebExtensions is not as good as it used to be with XUL/XPCOM. Please take a look at #9958 and #10822, particularly #9958 (comment), to understand the current status.

    Please post here again if you have follow up questions or problems, otherwise please close this issue.

  2. jeremyn commented on Aug 25, 2017

    @jeremyn
    Contributor

    If the custom ruleset files were there before you upgraded from the XUL/XPCOM version of the extension to the current "embedded WebExtensions" approach, then the rulesets should have been imported during a one-off process from the files to an internal storage mechanism. If you added or modified the ruleset files after you upgraded the extension to an embedded WebExtensions version, then you need to modify the about:config setting described in #9958 (comment) and restart the browser to re-run the import process.

    I agree the documentation is out of date. However this is all a work-in-progress, with the current approach decided on about three weeks ago (#11639 (comment)). The current approach is also just transitional until the full WebExtensions setup is released for Firefox 57, at which point the ruleset files won't be read at all. So I don't think documentation is a high priority at the moment.

  3. jeremyn commented on Aug 25, 2017

    @jeremyn
    Contributor

    Also,

    a text/plain dump to a browser tab which could be saved or copied and pasted would be beneficial

    sounds like the suggestion in issue #11794. Please feel free to add your thoughts on this interface to that issue.

  4. draconx commented on Sep 5, 2017

    @draconx

    If the custom ruleset files were there before you upgraded from the XUL/XPCOM version of the extension to the current "embedded WebExtensions" approach, then the rulesets should have been imported during a one-off process from the files to an internal storage mechanism.

    This process doesn't seem to actually work. With no documentation it's hard to know whether or not I did it correctly, but I have a large set of personal rules which I keep synchronized between multiple systems using git.

    All of my rules simply stopped being applied after "upgrading" to 2017.08.31. 5.2.21 works fine.

  5. jeremyn commented on Sep 5, 2017

    @jeremyn
    Contributor

    @draconx Have you tried setting extensions.https_everywhere.webextensions-migrated to false as described in #9958 (comment) to trigger a re-import of your custom rules?

  6. Hainish commented on Sep 25, 2017

    @Hainish
    Member

    This should be solved in 66293af. If not, please indicate and I can re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions