You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Embedded WebExtension on FF ESR does not work if JS is disabled #11948
After I got the 2017.8.15 update on my FF55 64Bit (Win10) the extension simply does not work anymore.
Before the update it correctly rewrote scummvm.org or 4chan.org, to name some examples (both are still listed on the atlas rule list as working). . After the update all domains I checked are not rewritten to HTTPS anymore and I suspect this is the case for all. I also checked a handful random ones from atlas, which where also not rewritten.
Also the new tab in the developers console does nothing - what exactly should iut do? I see an explanation and checkign the box does a reload, but then nothing happens. No matter if I'm on an unknown site (no matter if HTTP or HTTPS) or an know site (no matter if HTTP or HTTPS). Also no matter if mixed content.
Well, the extension still shows the GUI button. But is it supposed to not list matching rules anymore? And as I already posted: #11943 (which was a dupe as it turned out)
So, to me it seems that the GUI is correctly rendered, but none of the actual functionalities is working.
I tried purging the extension from my profile (deleting all occurences in about:config and delting all extension-related files in the profile folder), and reinstalling it cleanly. It did not help.
HTTPS Everywhere works for me for http://scummvm.org using Firefox v55.0.1, extension version 2017.8.15, Ubuntu 16.04. By "works" I mean if I watch the developer console Network tab and type "scummvm.org" into the address bar and press enter, the initial request is made to https://scummvm.org/ and gets a 301 response.
@foobar13373 Regarding about:config settings: none that I know of.
Could you please attach a screenshot showing what your add-on UI looks like, showing the box expanded that says "HTTPS Everywhere" with all the checkboxes?
dom.storage.enabled is set to true in my case. But I agree that this should not be required for the extension, I was often thinking about turning this off (didn't do it already because I need to find the real implications on the behavior). Aren't there other possibilities to store settings? Or at least making storage enabled for addons but not for web pages?
edit: Where does the extension store the rulesets? Seems they do not get loaded at all.
I just renamed my FF profile folder, started FF to create a fresh profile, installed HTTPS-E from eff.org - and it was working (even the block all unencypted checkbox).
So there surely must be some other setting that is influencing how/if HTTPS-E is working.
It is not working in my original profile, even if I disable all addons (uBlock Origin + Decentral Eyes) and only leave HTTPS-E active.
I have safebrowsing off, OCSP off (generally I turn features bugs off that trigger requests to locations that are not requested by me in some way, either by entering it in the bar or by willingly enabling an add-on by hand) and opted in for e10s.
No. I only use a regular FF 55 with HTTPS-E, uBlock Origin (block everything by default, then whitelist allowed requests on a per domain base), Decentral Eyes. With home-calling off (OCSP, "safe" browsing, address bar suggestions, status/crash reports etc.). Cookies are disabled (I enable some sites by hand), browser history is cleaned on exit. DRM is disabled. All shipped search engines are removed and replaced by Duck Duck Go. Passwords / form data are never stored.
All this through the regular preferences dialogue. I think only opting-in for e10s was actually done by editing about:config by hand. But iirc e10s is enabled by default now anyways, isn't it?
I could isolate the problem. And it is really strange. I created a clean profile again, installed only HTTPS-E. It was working. Then I switched setting by setting in the regular settings dialogue and restarted the browser every time. So I tested each setting separately.
HTTPS Everywhere is not working if you choose custom privacy settings and disable cookies at all and restart the browser!
So, for some strange reason the extension is depending on cookies now?
I tried this on scummvm.org again. Oh, and also the HTTPS-E WebDev console tab was working now, with cookies enabled.
I inspected the cookies and there was no sign of a HTTPS-E cookie, only the spyware cookies from Google and PayPal.
@foobar13373 I can confirm your results, that is, that unchecking "Accept cookies from sites" in about:preferences#privacy and restarting Firefox will cause HTTPS Everywhere to not rewrite http://scummvm.org to HTTPS. Good catch!
@Hainish
HTTPS-E works now if cookies are disabled and localStorage is enabled. Having both, cookies and localStorage (dom.storage.enabled set to false), disabled, shows the same behaviour as before (HTTPS-E not working at all).
Latest version still doesn't work with imgur links like this one: http://i.imgur.com/ia1NcWr.jpg but it does work for http://imgur.com/
Tested using a new Firefox profile, default settings and no other add-ons.
@user684 @koops76 simply accessing localStorage raises a security exception. In the current version I've surrounded all localStorage references in a try/catch.
changed the title [-]Version 2017.8.15 on FF does not work if cookies, JS are disabled[/-][+]Version 2017.8.15 on FF ESR does not work if JS is disabled[/+]on Aug 19, 2017
changed the title [-]Version 2017.8.15 on FF ESR does not work if JS is disabled[/-][+]Embedded WebExtension on FF ESR does not work if JS is disabled[/+]on Aug 19, 2017
Activity
Folant commentedon Aug 16, 2017
I'm getting the same behaviour on Win10 FF55.0.2(64b)/Tor 7.0.4(32b)
#11944 somewhat related, probably. But I can't get it to work even on "Low".
jeremyn commentedon Aug 17, 2017
HTTPS Everywhere works for me for http://scummvm.org using Firefox v55.0.1, extension version 2017.8.15, Ubuntu 16.04. By "works" I mean if I watch the developer console Network tab and type "scummvm.org" into the address bar and press enter, the initial request is made to https://scummvm.org/ and gets a 301 response.
foobar13373 commentedon Aug 17, 2017
@jeremyn
In my installation the request goes exactly to where it was made. A HTTP request to scummvm.org stays on plain http.
I tried with all my other extension (uBlock Origin and Decentral Eyes) disabled and enabled. Same behavior in both cases.
Are there any settings in about:config that could influence HTTPS Everwhere's core functionality in the new version?
jeremyn commentedon Aug 17, 2017
@foobar13373 Regarding about:config settings: none that I know of.
Could you please attach a screenshot showing what your add-on UI looks like, showing the box expanded that says "HTTPS Everywhere" with all the checkboxes?
jeremyn commentedon Aug 17, 2017
dom.storage.enabledis enabled for me in about:config and according to Firefox, enabled (true) is the default setting.jeremyn commentedon Aug 17, 2017
@user684 We have to store persistent settings somewhere.
foobar13373 commentedon Aug 17, 2017
Screenshot (using scummvm.org as an example):
dom.storage.enabledis set totruein my case. But I agree that this should not be required for the extension, I was often thinking about turning this off (didn't do it already because I need to find the real implications on the behavior). Aren't there other possibilities to store settings? Or at least making storage enabled for addons but not for web pages?edit: Where does the extension store the rulesets? Seems they do not get loaded at all.
foobar13373 commentedon Aug 17, 2017
I just renamed my FF profile folder, started FF to create a fresh profile, installed HTTPS-E from eff.org - and it was working (even the block all unencypted checkbox).
So there surely must be some other setting that is influencing how/if HTTPS-E is working.
foobar13373 commentedon Aug 17, 2017
It is not working in my original profile, even if I disable all addons (uBlock Origin + Decentral Eyes) and only leave HTTPS-E active.
I have safebrowsing off, OCSP off (generally I turn
featuresbugs off that trigger requests to locations that are not requested by me in some way, either by entering it in the bar or by willingly enabling an add-on by hand) and opted in for e10s.foobar13373 commentedon Aug 17, 2017
No. I only use a regular FF 55 with HTTPS-E, uBlock Origin (block everything by default, then whitelist allowed requests on a per domain base), Decentral Eyes. With home-calling off (OCSP, "safe" browsing, address bar suggestions, status/crash reports etc.). Cookies are disabled (I enable some sites by hand), browser history is cleaned on exit. DRM is disabled. All shipped search engines are removed and replaced by Duck Duck Go. Passwords / form data are never stored.
All this through the regular preferences dialogue. I think only opting-in for e10s was actually done by editing about:config by hand. But iirc e10s is enabled by default now anyways, isn't it?
foobar13373 commentedon Aug 17, 2017
I could isolate the problem. And it is really strange. I created a clean profile again, installed only HTTPS-E. It was working. Then I switched setting by setting in the regular settings dialogue and restarted the browser every time. So I tested each setting separately.
HTTPS Everywhere is not working if you choose custom privacy settings and disable cookies at all and restart the browser!
So, for some strange reason the extension is depending on cookies now?
I tried this on scummvm.org again. Oh, and also the HTTPS-E WebDev console tab was working now, with cookies enabled.
I inspected the cookies and there was no sign of a HTTPS-E cookie, only the spyware cookies from Google and PayPal.
Hainish commentedon Aug 17, 2017
Thanks for the report @foobar13373. I'm looking into this now.
jeremyn commentedon Aug 17, 2017
@foobar13373 I can confirm your results, that is, that unchecking "Accept cookies from sites" in about:preferences#privacy and restarting Firefox will cause HTTPS Everywhere to not rewrite http://scummvm.org to HTTPS. Good catch!
jeremyn commentedon Aug 17, 2017
@foobar13373 By the way, you can work with profiles using
about:profiles. You don't need to rename folders or anything like that.25 remaining items
Hainish commentedon Aug 18, 2017
@jylr this is expected, see https://bugzilla.mozilla.org/show_bug.cgi?id=1329731 and https://trac.torproject.org/projects/tor/ticket/23258#comment:25
jylr commentedon Aug 18, 2017
I see, thanks.
jeremyn commentedon Aug 18, 2017
@Hainish The problem I described in #11948 (comment) reproducing @foobar13373 's original issue, is fixed for me.
foobar13373 commentedon Aug 18, 2017
@Hainish
HTTPS-E works now if cookies are disabled and localStorage is enabled. Having both, cookies and localStorage (
dom.storage.enabledset tofalse), disabled, shows the same behaviour as before (HTTPS-E not working at all).foobar13373 commentedon Aug 18, 2017
Just for the record: @gorhill is facing similar issues in uBlock Origin:
gorhill/uBlock#2824
There's his solution: gorhill/uBlock@6fb6b4e
Kezxo commentedon Aug 18, 2017
Latest version still doesn't work with imgur links like this one: http://i.imgur.com/ia1NcWr.jpg but it does work for http://imgur.com/
Tested using a new Firefox profile, default settings and no other add-ons.
foobar13373 commentedon Aug 18, 2017
I can confirm this. But it seems to be another issue, it's not related to JS, cookies or storage.
Hainish commentedon Aug 18, 2017
@user684 @koops76 simply accessing localStorage raises a security exception. In the current version I've surrounded all localStorage references in a
try/catch.jeremyn commentedon Aug 19, 2017
@Kezxo The Imgur problem is being tracked in issue #11981.
[-]Version 2017.8.15 on FF does not work if cookies, JS are disabled[/-][+]Version 2017.8.15 on FF ESR does not work if JS is disabled[/+][-]Version 2017.8.15 on FF ESR does not work if JS is disabled[/-][+]Embedded WebExtension on FF ESR does not work if JS is disabled[/+]Hainish commentedon Aug 23, 2017
At this point, this seems to be out of our control. https://bugzilla.mozilla.org/show_bug.cgi?id=1329731 is the issue to track for this.
Stopgap fix: if localStorage is unavailable, mock out object for in-m…