Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Blocking non-encrypted traffic not working in FF #11943

Closed

Description

@foobar13373

I just got Version "2017.8.15" in FF55 (64Bit) on Win10 and the checkbox to block all non-encrypted traffic does not work at all. It does not get saved and no http-content is blocked.

Also, how can I enable/disable rules with this new interface?

Activity

  1. HTTPSNowhere commented on Aug 16, 2017

    @HTTPSNowhere
    Contributor

    Duplicate #10150

  2. aemixdp commented on Aug 17, 2017

    @aemixdp

    Exactly the same issue in Chrome. It worked perfect few days ago.

  3. gripedthumbtacks commented on Aug 18, 2017

    @gripedthumbtacks

    i can also confirm this issue on chrome. very strange

  4. Hainish commented on Aug 19, 2017

    @Hainish
    Member

    I'm not experiencing this behavior on Firefox 55 or the latest Chromium. Are you still seeing this on >= 2017.8.17?

  5. foobar13373 commented on Aug 20, 2017

    @foobar13373
    Author

    @Hainish
    With your latest changes regarding the localStorage, this is also working for me in the currently running browser session. This means:

    The checkbox state is saved between browser starts, but the functionality only works if one dis- and re-enables the checkbox after a browser restart (which comes from clearing the storage on exit, I assume).

  6. ansell commented on Aug 21, 2017

    @ansell

    I was seeing unencrypted requests succeeding with 2017.8.19 on Firefox-55.0.2 until I unchecked, and then came back and checked the setting again. Before doing that, the icon was also not red, as it was previously, but after that process, it is red again.

  7. Hainish commented on Aug 22, 2017

    @Hainish
    Member

    @foobar13373 glad to hear the latest changes fixed this issue, unless I'm misunderstanding. Feel free to close if this is no longer an issue.

  8. ivan-kolmychek commented on Aug 29, 2017

    @ivan-kolmychek

    @Hainish I think you've missed this part

    but the functionality only works if one dis- and re-enables the checkbox after a browser restart (which comes from clearing the storage on exit, I assume).

    which is not how addon was working before for me - the flag, icon state and functionality state were consistently being saved and restored after I've closed browser and opened it again.

    It would be really cool if you can not worry about re-enabling it every time you open the browser. :)

    Can we get that behavior back again? Is it blocked by something?

  9. gripedthumbtacks commented on Aug 29, 2017

    @gripedthumbtacks

    right, this is actually now a SECURITY ISSUE. for instance, you close your browser on a secure network, then move to another network that is hostile, open the saved browser and all your traffic and cookies potentially leak over HTTP without protection. same bug also confirmed in chrome version of extension

  10. gripedthumbtacks commented on Aug 29, 2017

    @gripedthumbtacks

    opened #12190 to track wider issue

  11. gripedthumbtacks commented on Aug 29, 2017

    @gripedthumbtacks

    could potentially fix this security bug by simply changing

    pref("extensions.https_everywhere.http_nowhere.enabled", false);

    to

    pref("extensions.https_everywhere.http_nowhere.enabled", true);

    in

    src/defaults/preferences/preferences.js

    and making it more secure by default, requiring users to downgrade to the less secure option if they choose

  12. Hainish commented on Aug 29, 2017

    @Hainish
    Member

    Can someone give me specific steps to reproduce this error? The description given is not reproducing this for me, but it may be that I'm not following the exact same workflow.

  13. Hainish commented on Aug 29, 2017

    @Hainish
    Member

    @DtpEJsaYXDU4GDH8dE4MyI9VrieF0UZpPZ0K76K this will not work. The WebExtension has no access to the old preferences that the legacy XPCOM extension drew from.

  14. gripedthumbtacks commented on Aug 30, 2017

    @gripedthumbtacks

    This issue started about two weeks ago in both Firefox and chrome. To reproduce, here are some potential steps.

    Install extension

    Enable no http mode

    Close browser

    Reopen browser. Notice that the setting is disabled (icon is blue), even if the option appears enabled. Enabled icon color is red when one.

    Try chrome as well.

  15. ansell commented on Aug 30, 2017

    @ansell

    I am seeing the same behaviour as @DtpEJsaYXDU4GDH8dE4MyI9VrieF0UZpPZ0K76K My workaround above of disabling and re-enabling doesn't seem to be persisted across Firefox executions. When starting up Firefox, the icon is blue (I haven't noticed it flickering from red to blue myself), but the checkbox beside "Block all unencrypted requests" is checked, which matches the expected preference since it was checked on the previous Firefox execution.

  16. jimmycuadra commented on Aug 30, 2017

    @jimmycuadra

    I have been experiencing the exact same behavior described by @ansell in Chrome.

  17. Bisaloo commented on Aug 30, 2017

    @Bisaloo
    Collaborator

    I was waiting to hear more on this issue but this looks like an exact duplicate of #10478.

  18. Hainish commented on Aug 30, 2017

    @Hainish
    Member

    This behavior is not observed in Firefox 52.3.0 but interestingly is observed in 55.0.1. Possible Firefox regression? Looking into this further now.

  19. gripedthumbtacks commented on Aug 30, 2017

    @gripedthumbtacks

    Doubt it could only be a regression in firefox if this issue ALSO affects chrome.

  20. Hainish commented on Aug 30, 2017

    @Hainish
    Member

    This stems from a race condition between the setting of the storage object in

    storage = chrome.storage.sync;
    and the retrieval of background.js stored global variables in
    storage.get({
    httpNowhere: false,
    showCounter: true,
    globalEnabled: true
    }, function(item) {
    httpNowhereOn = item.httpNowhere;
    showCounter = item.showCounter;
    isExtensionEnabled = item.globalEnabled;
    updateState();
    });
    . #12268 fixes this.

  21. Hainish commented on Aug 30, 2017

    @Hainish
    Member

    I can make a release tomorrow with this change.

  22. ivan-kolmychek commented on Sep 1, 2017

    @ivan-kolmychek

    Works for me now, thank you @Hainish.

  23. own2k commented on Sep 2, 2017

    @own2k

    It's good to update release in FF addons now. Who does that, by the way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions